Include Python and Julia version in PySR env#365
Closed
MilesCranmer wants to merge 5 commits intomasterfrom
Closed
Include Python and Julia version in PySR env#365MilesCranmer wants to merge 5 commits intomasterfrom
MilesCranmer wants to merge 5 commits intomasterfrom
Conversation
Contributor
|
It is not clear to me that this will work because I'm not sure if PyCall.jl has localized the Python setting to the environment. What we need is for PyCall.jl is to implement |
Owner
Author
|
Here is the PR: JuliaPy/PyCall.jl#945 Since it’s 2 years old with no recent updates maybe the solution in the meantime is to just delete the PyCall deps whenever someone installs PySR? |
Owner
Author
|
Actually it probably makes sense to include this regardless for the Julia tag, because the Manifest file might be incompatible (say some Julia package differs for older Julia versions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than
@pysr-0.14.2as the Julia environment, this would make it@pysr-0.14.2-py-3.11-jl-1.9. Thus the user would need to re-install for each combination of Python and Julia they wish to use PySR with. This is to prevent some of the issues noted in #257cc @mkitti @ngam I wonder if this would pose an issue for conda at all? If I install a different
juliaversion in conda, it would also trigger a new PySR install, right?