Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where custom row actions were not visible in grids when no standard actions (copy, update, view, delete) were enabled, and includes refactoring to support multiple UI frameworks beyond Blazor.
Key changes:
- Fixed the actions menu visibility calculation to include custom row actions
- Added
INotifyPropertyChangedimplementation to the baseViewModelclass - Introduced new strongly-typed methods (
Table,SectionList,ReorderableSectionList) to replace the genericFormFieldmethod for list fields - Added new
FormFieldTypeenum values with corresponding documentation
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Mimeo.DynamicUI/ViewModel.cs | Added INotifyPropertyChanged support and new list field helper methods; deprecated old FormField overloads |
| Mimeo.DynamicUI/TextFieldDefinition.cs | Made Items property auto-detect Combobox type for backwards compatibility |
| Mimeo.DynamicUI/ListFieldDefinition.cs | Added new constructor with FormFieldType parameter and deprecated old PresentationMode property |
| Mimeo.DynamicUI/FormFieldType.cs | Added Combobox, Table, SectionList, ReorderableSectionList enum values with documentation |
| Mimeo.DynamicUI/FormFieldDefinition.cs | Added DescriptionLanguageKey property |
| Mimeo.DynamicUI/Data/OData/ODataExpressionGenerator.cs | Extended filter operator support to new list field types |
| Mimeo.DynamicUI.Demo/Mimeo.DynamicUI.Demo.Shared/ViewModels/TestViewModel.cs | Updated demo to use new list field methods and removed redundant INotifyPropertyChanged implementations |
| Mimeo.DynamicUI.Blazor/Forms/ODataGrid.razor.cs | Fixed actions menu visibility to include custom row actions |
| Mimeo.DynamicUI.Blazor/FormFields/ListField.razor | Updated to check FormFieldType instead of deprecated PresentationMode |
| Mimeo.DynamicUI.Blazor/FormFields/DynamicField.cs | Added mappings for new form field types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tlatrace-mimeo
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.