feat: implement quest expiry enforcement with on-chain timestamp vali…#226
Open
JoaquinSkorg wants to merge 1 commit into
Open
feat: implement quest expiry enforcement with on-chain timestamp vali…#226JoaquinSkorg wants to merge 1 commit into
JoaquinSkorg wants to merge 1 commit into
Conversation
…dation - Add timestamp guard in complete_quest to prevent expired quest completion - Require current_time < quest.expires_at for successful completion - Emit QUEST_EXPIRED event when quest is past its deadline - Add comprehensive test coverage for expiry scenarios: - test_complete_quest_before_expiry_succeeds: verify pre-expiry completion - test_complete_quest_exactly_at_expiry_fails: boundary condition at exact timestamp - test_complete_quest_after_expiry_fails: reject post-expiry attempts - test_complete_quest_no_expiry_always_succeeds: handle indefinite quests - test_expiry_event_emitted_on_rejection: verify event publication - test_expiry_event_panic_message_correct: validate panic message - All 32 tests passing with expiry enforcement active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219
Modifications made and changes pass the criteria. Kindly review.