feat(routing): fix tsconfig deprecations, resolve Navbar runtime crashes, and implement 404 fallback#105
Open
Nacho1499 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83
PR Description:
This PR resolves modern environment configuration warnings, fixes immediate app-crashing bugs inside the primary navigation component, and sets up a bulletproof fallback architecture for handling invalid route errors.
Changes Checklist:
Compiler & Config:
--tsconfig.json: Removed the deprecated "baseUrl" option to prevent upcoming compilation errors in TypeScript 7.0+. Added "ignoreDeprecations": "6.0" to silence the modern compiler error block.
--Route & Fallback Infrastructure:
src/App.jsx: Stripped out legacy, complex window hash checks to rely completely on clean, browser-native routing context path trackers.
--404 Catch-All: Structured a native universal catch-all route (<Route path="*" element={} />) inside your core engine to gracefully intercept unrecognized application routing states.
Navbar Component Repair:
-Fixed a runtime application crash by explicitly importing Link from react-router-dom.
-Generated a missing unique accessibility ID (mobileMenuId) using React's useId() hook to cleanly link the mobile hamburger menu buttons.
-Added a functional handleLogout code stub to prevent breaking click executions when interacting with the dashboard log-out utility.
-Corrected broken mobile drawer panel asset paths from .png formats back to their primary .svg variations.