Merged
Conversation
# Conflicts: # CHANGELOG.md
tomca32
approved these changes
Apr 8, 2026
Member
tomca32
left a comment
tomca32
left a comment
There was a problem hiding this comment.
Good work. Ordering also makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature for #2497
#editand#updateto skill routingskill_form_component.html.erbto checkskill.grade_descriptorsby their marksDisclaimer when testing
Only real issue was the way grade descriptors were shown in both the web app and mobile app. When a grade descriptor was updated it was returned first in the queries, therefore the lesson grading dropdowns would show grade descriptor with mark '3' as first. Same goes for the mobile app, the grading slider would show the first option to be the descriptor with a mark '3'.
Above is the reason why default ordering was added.