fix: /fly command #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added default value (1.0) to the /fly command. Also made the /fly [float] command actually change the player's fly speed based on the input.
Enables /fly and /fly [speed] forms without causing the /fly form to reset the speed to 1. Behavior is as follows: If player sends /fly 5, their speed is set to 5 If player sends /fly, then /fly again (re-enabling flight), their speed is still 5. Previously, their speed will have been set to 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /fly command currently requires an additional float argument that is not used for anything. This PR introduces 2 fixes: