Repository navigation
Store each deployment model default field once - #836
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment model defaults sealed the whole configuration while the same non-secret fields also sat in plaintext columns, which listing, admission and observation read. The sealed value is now the provider key alone, the columns are the only copy of everything else, and
LoadBundlerebuilds the configuration from one row. Migration 000005 renamesencrypted_configtoencrypted_api_keyand removes stored defaults, which cannot be converted in SQL; set them again. No API change; no doc described the storage.Need help on this PR? Tag
@codesmith-botwith what you need.