Repository navigation
Update Session settings and review, bound per root Turn - #920
Merged
Merged
Conversation
A metadata-only update no longer re-validates the Session configuration, and the settings columns need no backfill because there are no in-place upgrades.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official Session update now covers
agent.model,agent.reasoning.effort,agent.service_tierandreview, and each root Turn binds its settings when Core accepts the input that creates it (Agents API pin 3.45.0). No Harness declares these changes yet, so after this change every real change returns a typed 400. The Codex and Claude Code changes flip their declarations.Behavior
model;reasoning.effort(null resets);service_tier(null becomesauto);review;metadata.agent.toolsreturns 400 with paramagent.tools.agentorreview, the result is validated against the Harness declaration, and a changed setting the Harness cannot apply between root Turns returns 400unsupported_or_invalid_configurationnaming the field.reviewon create and update is validated against the declaration (Execution.Reviews), which replaces the hard-codedauto_reviewrejection. The value is stored and rendered only forauto_review.turns.settingsandenvironment_input_reservations.settingshold{model, reasoning_effort, service_tier, review}, projected by one function,sessions.TurnSettingsOf. Dispatch buildsproto.TurnSettingsfrom them, not from the Session snapshot, so a Turn queued before an update keeps its values.sessionafter an update changes the model.harnessconfiggainsSessionUpdates{Model, ReasoningEffort, ReasoningEffortReset, ServiceTier}andExecution.Reviews. Every built-in Harness declares them Unsupported or empty.No protocol change.
Deleted
UpdateSessionMetadata,rejectAutoReview, and the snapshot-based Turn settings path.agentandreviewrows of the unsupported-fields test.Docs
English and
zh/:index.md,wire-semantics.md,model-execution.md,admin-api.md,harness-capabilities.md(every Harness rejects these updates for now), and the "Declare the Harness" paragraph ofharness-onboarding.md.Verification
go vetpasses.go testpasses forinternal/harnessconfig/...and Coreapi,sessions,executionandsessionpg.make openapi,check-sqlc,check-harness-catalog,check-docsandcheck-translationspass.official_session_metadata.pyruns in CI.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.