Repository navigation
Let the Environment own its lifecycle - #930
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
…for the Environment-owned rows
…cutor preparation
…ation and input failure without a Harness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Environment now owns its lifecycle. This prepares standalone, reusable Environments; the public API follows in a later PR.
000014_first_class_environments):environmentsgainstenant_id, its frozenconfigurationandsession_owned, plus the creation-identity columns and constraints that standalone Environments will use.sessions.environment_idnames the Environment. The unique indexsessions_attached_environmentallows at most one live Session per Environment.environment_setups,initial_environment_files) is keyed byenvironment_id.environmentstosessionsnow reads the Environment's own tenant, configuration and attachment. The two views are recreated.sessionpg.WithEnvironmentlocks the attached Session, if any, then the Environment, and re-checks the attachment. Workspace work uses the same lock.sessions.EnvironmentgainsTenantID,SessionOwnedandAttachedSessionID.deployment.AllocationusesAttachedSessionIDandReclaimed.EnvironmentInitializationno longer carries a Session or Harness.configuration.environmentis composed from its Environment's row.runtime_preparation_failed, and the Environment is unaffected. This is the only behavior change.sessions.ProvisioningHarnessis deleted.Docs updated in EN and zh:
services/core/IMPLEMENTATION.md,contracts/agents-api/environments.md,docs/sandbox-provider.mdand the diagnostics text.Checks
go vet ./services/core/...andscripts/check-sqlc.py.sessions,deployment,execution,api,runtimehistoryandruntimeenrollment.pnpm --dir website check-translations.This PR and the standalone Environments API PR get one combined blind review.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.