Added example code for watts-strogatz model and algorithms for dynamic linear topology based on probability value. - #145
Open
CianGrimnir wants to merge 5 commits into
Open
Added example code for watts-strogatz model and algorithms for dynamic linear topology based on probability value.#145CianGrimnir wants to merge 5 commits into
CianGrimnir wants to merge 5 commits into
Conversation
…c linear topology based on probability value.
CianGrimnir
requested review from
atriMukhopadhyay,
juraul1,
lantz and
ruffinim
September 30, 2022 19:34
Collaborator
|
you migth need to add matplotlib in requirements.txt? I think that's why the tests are not passing |
CianGrimnir
commented
Oct 3, 2022
| conn6_file.close() | ||
| conn7_file.close() | ||
| conn8_file.close() | ||
| if 'test' in argv: |
Author
There was a problem hiding this comment.
@juraul1 I have updated the requirements.txt files with the deps, but the test is failing because of incomplete test cases. Do I have to write the test case for this setup, or can I comment out this test snippet?
Collaborator
There was a problem hiding this comment.
@CianGrimnir [edit] Actually we should have a test for that. But I'm not sure the ping test is what you're looking for. We can discuss about it but first it could be nice if you could explain your code to us?
You can comment out the test part for now and see if it passes (although I'm not sure that's the problem), but later we will need a test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.