chore(ci): bump actions/download-artifact from 4.3.0 to 8.0.1#38
chore(ci): bump actions/download-artifact from 4.3.0 to 8.0.1#38dependabot[bot] wants to merge 1 commit into
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
lml2468
left a comment
There was a problem hiding this comment.
[APPROVE β self-review, posting as COMMENT] Correct SHA-pinned bump.
β
download-artifact 4.3.0 β 8.0.1: SHA updated d3f86a1 β 3e5f45b, version comment updated.
upload-artifact 4β7): upload and download artifact actions must use a compatible storage backend. Recommend merging #36 and #38 in the same batch and verifying the workflow end-to-end after merge (the multi-arch digest upload β merge job path in docker-publish.yml).
Ready to merge alongside #36.
Jerry-Xin
left a comment
There was a problem hiding this comment.
One-line summary: The PR is in scope and safely updates the Docker publish workflowβs artifact download action.
β Highlights
- π΅ Verified
.github/workflows/docker-publish.yml:223: the pinned SHA matches upstreamactions/download-artifactv8.0.1. - π΅ The download step runs on
ubuntu-latest, so thedownload-artifact@v7+Node 24 runner requirement is satisfied. - π΅ The existing
upload-artifact@v4.6.2digest artifacts andmerge-multiple: trueflow remain compatible with the upgraded download action. - π΅ The stricter v8 digest mismatch default is desirable here; failing the publish workflow on artifact integrity mismatch is appropriate.
No blocking issues found. No test changes are needed for this one-line CI dependency bump.
lml2468
left a comment
There was a problem hiding this comment.
[APPROVE β COMMENT due to self-review restriction] Independent cross-review.
Verified:
- SHA pin β
3e5f45b2cfb9172054b4087a40e8e0b5a5461e7cmatchesactions/download-artifacttagv8.0.1. β - Usage compatibility β
with: { path, pattern, merge-multiple }inputs are stable across v4βv8. Thepattern: digests-*+merge-multiple: trueusage is supported since v4.1.0. β - Pairs with PR #36 β
upload-artifactbumped to v7.0.1. Both use the same Artifacts v2 backend; v8 download is wire-compatible with v7 upload. β - CI β All checks green. β
No blocking issues. Recommend merging alongside or after PR #36 for a clean pair.
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.3.0 to 8.0.1. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@d3f86a1...3e5f45b) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 8.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
58b31e2 to
7b56b9f
Compare
Bumps actions/download-artifact from 4.3.0 to 8.0.1.
Release notes
Sourced from actions/download-artifact's releases.
... (truncated)
Commits
3e5f45bAdd regression tests for CJK characters (#471)e6d03f6Add a regression test for artifact name + content-type mismatches (#472)70fc10cMerge pull request #461 from actions/danwkennedy/digest-mismatch-behaviorf258da9Add change docsccc058eFix linting issuesbd7976bAdd a setting to specify what to do on hash mismatch and default it toerrorac21fcfMerge pull request #460 from actions/danwkennedy/download-no-unzip15999bfAdd note about package bumps974686eBump the version tov8and add release notesfbe48b1Update test names to make it clearer what they do