Skip to content

chore(deps): bump react and @types/react#44

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/multi-e2615a3a50
Open

chore(deps): bump react and @types/react#44
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/multi-e2615a3a50

Conversation

@dependabot
Copy link
Copy Markdown

@dependabot dependabot Bot commented on behalf of github May 21, 2026

Bumps react and @types/react. These dependencies needed to be updated together.
Updates react from 18.3.1 to 19.2.6

Release notes

Sourced from react's releases.

19.2.6 (May 6th, 2026)

React Server Components

19.2.5 (April 8th, 2026)

React Server Components

19.2.4 (January 26th, 2026)

React Server Components

19.2.3 (December 11th, 2025)

React Server Components

19.2.2 (December 11th, 2025)

React Server Components

19.2.1 (December 3rd, 2025)

React Server Components

19.2.0 (Oct 1, 2025)

Below is a list of all new features, APIs, and bug fixes.

Read the React 19.2 release post for more information.

New React Features

  • <Activity>: A new API to hide and restore the UI and internal state of its children.
  • useEffectEvent is a React Hook that lets you extract non-reactive logic into an Effect Event.
  • cacheSignal (for RSCs) lets your know when the cache() lifetime is over.
  • React Performance tracks appear on the Performance panel’s timeline in your browser developer tools

New React DOM Features

  • Added resume APIs for partial pre-rendering with Web Streams:
  • Added resume APIs for partial pre-rendering with Node Streams:

... (truncated)

Changelog

Sourced from react's changelog.

19.2.1 (Dec 3, 2025)

React Server Components

19.2.0 (October 1st, 2025)

Below is a list of all new features, APIs, and bug fixes.

Read the React 19.2 release post for more information.

New React Features

  • <Activity>: A new API to hide and restore the UI and internal state of its children.
  • useEffectEvent is a React Hook that lets you extract non-reactive logic into an Effect Event.
  • cacheSignal (for RSCs) lets your know when the cache() lifetime is over.
  • React Performance tracks appear on the Performance panel’s timeline in your browser developer tools

New React DOM Features

  • Added resume APIs for partial pre-rendering with Web Streams:
  • Added resume APIs for partial pre-rendering with Node Streams:
  • Updated prerender APIs to return a postponed state that can be passed to the resume APIs.

Notable changes

  • React DOM now batches suspense boundary reveals, matching the behavior of client side rendering. This change is especially noticeable when animating the reveal of Suspense boundaries e.g. with the upcoming <ViewTransition> Component. React will batch as much reveals as possible before the first paint while trying to hit popular first-contentful paint metrics.
  • Add Node Web Streams (prerender, renderToReadableStream) to server-side-rendering APIs for Node.js
  • Use underscore instead of : IDs generated by useId

All Changes

React

... (truncated)

Commits

Updates @types/react from 18.3.28 to 19.2.15

Commits

@dependabot @github
Copy link
Copy Markdown
Author

dependabot Bot commented on behalf of github May 21, 2026

Labels

The following labels could not be found: dependencies. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot Bot requested a review from a team as a code owner May 21, 2026 12:05
@github-actions github-actions Bot added size/XS PR size: XS dependencies-changed This PR modifies dependency files labels May 21, 2026
@github-actions
Copy link
Copy Markdown

Dependency Changes Detected

This PR modifies dependency files. Please review whether these changes are intentional.

Changed files:

  • package.json

Maintainer checklist:

  • Confirm dependency changes are intentional
  • Review package delta if lockfile changed

Copy link
Copy Markdown

@Jerry-Xin Jerry-Xin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is in scope, but it leaves the React dependency set inconsistent and the project cannot install cleanly.

πŸ”΄ Blocking

  • πŸ”΄ Critical β€” package.json:23-30 upgrades react and @types/react to 19.x, but leaves react-dom and @types/react-dom on 18.x. This creates peer dependency conflicts: react-dom@18.3.1 peers on react@^18.3.1, and @types/react-dom@18.3.7 peers on @types/react@^18.0.0 as shown in package-lock.json:1683-1691 and package-lock.json:3823-3834. npm ci fails with ERESOLVE could not resolve before build or tests can run. Please either upgrade react-dom and @types/react-dom to compatible 19.x versions, or keep React and its types on 18.x.

πŸ’¬ Non-blocking

  • 🟑 Warning β€” The lockfile also rewrites many resolved URLs from registry.npmmirror.com to registry.npmjs.org. That is not a correctness blocker by itself, but it is unrelated churn for this PR and may affect install behavior for contributors relying on the previous mirror.

βœ… Highlights

  • The PR only changes dependency metadata and is relevant to the octo-admin application.
  • I reviewed the full PR diff and attempted validation with npm ci; build/test validation is currently blocked by the dependency resolver failure.

Copy link
Copy Markdown
Contributor

@lml2468 lml2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[CHANGES_REQUESTED] Independent cross-review. Concur with Allen's findings.

πŸ”΄ Blocking: Partial React major version bump breaks install

CI build failure confirmed β€” npm ci hits ERESOLVE on Node 18:

While resolving: @types/react-dom@18.3.7
Found: @types/react@19.2.15
Could not resolve dependency:
peer @types/react@"^18.0.0" from @types/react-dom@18.3.7

The PR bumps react and @types/react from 18β†’19 but leaves their counterparts behind:

  • react-dom still at ^18.3.1 (peers on react@^18)
  • @types/react-dom still at ^18.3.6 (peers on @types/react@^18.0.0)

This is a Dependabot limitation β€” it grouped react + @types/react but missed the react-dom + @types/react-dom pair because they're separate packages.

Required fix: Either:

  1. Bump all four together: react, react-dom, @types/react, @types/react-dom to 19.x, OR
  2. Close this PR and configure Dependabot to group all React packages:
    groups:
      react:
        patterns:
          - "react"
          - "react-dom"
          - "@types/react"
          - "@types/react-dom"

⚠️ Note: React 18β†’19 is a major version bump with breaking changes (ref removal, useRef requires argument, new JSX transform, etc.). A dedicated migration PR with testing is recommended over an auto-merge Dependabot bump.

Copy link
Copy Markdown
Contributor

@lml2468 lml2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”΄ [REQUEST_CHANGES β€” self-review, posting as COMMENT] React 19 is a major breaking upgrade β€” needs explicit sign-off.

react + @types/react 18.3.x β†’ 19.2.x:

πŸ”΄ High-impact breaking change. React 19 removes several APIs that were deprecated in React 18:

  • ReactDOM.render() β†’ already removed (use createRoot)
  • string refs β†’ removed
  • Legacy Context API patterns β†’ changed
  • @types/prop-types removed from @types/react (seen in the diff: node_modules/@types/prop-types deleted)

πŸ”΄ antd 5.24.6 compatibility: antd 5.x officially supports react >=16.9.0 in its peer deps, but real-world React 19 compatibility for antd 5.x is mixed β€” antd 5 was designed for React 18. The safe upgrade path is antd 5.x + React 18 or antd 6.x + React 19. Current setup uses antd 5.24.6, which may have runtime issues with React 19.

πŸ”΅ Recommendation: Either

  1. Hold this PR and first evaluate upgrading antd to 6.x, then upgrade React to 19 together; or
  2. Run a full integration test with React 19 + antd 5.24.6 and document results.

Do not merge without explicit team review and test validation.

Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together.

Updates `react` from 18.3.1 to 19.2.6
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/v19.2.6/packages/react)

Updates `@types/react` from 18.3.28 to 19.2.15
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-version: 19.2.15
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: react
  dependency-version: 19.2.6
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/multi-e2615a3a50 branch from 88d9877 to dd2a41b Compare May 30, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies-changed This PR modifies dependency files size/XS PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants