chore(deps): bump react and @types/react#44
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Dependency Changes DetectedThis PR modifies dependency files. Please review whether these changes are intentional. Changed files:
Maintainer checklist:
|
Jerry-Xin
left a comment
There was a problem hiding this comment.
The PR is in scope, but it leaves the React dependency set inconsistent and the project cannot install cleanly.
π΄ Blocking
- π΄ Critical β
package.json:23-30upgradesreactand@types/reactto 19.x, but leavesreact-domand@types/react-domon 18.x. This creates peer dependency conflicts:react-dom@18.3.1peers onreact@^18.3.1, and@types/react-dom@18.3.7peers on@types/react@^18.0.0as shown inpackage-lock.json:1683-1691andpackage-lock.json:3823-3834.npm cifails withERESOLVE could not resolvebefore build or tests can run. Please either upgradereact-domand@types/react-domto compatible 19.x versions, or keep React and its types on 18.x.
π¬ Non-blocking
- π‘ Warning β The lockfile also rewrites many
resolvedURLs fromregistry.npmmirror.comtoregistry.npmjs.org. That is not a correctness blocker by itself, but it is unrelated churn for this PR and may affect install behavior for contributors relying on the previous mirror.
β Highlights
- The PR only changes dependency metadata and is relevant to the
octo-adminapplication. - I reviewed the full PR diff and attempted validation with
npm ci; build/test validation is currently blocked by the dependency resolver failure.
lml2468
left a comment
There was a problem hiding this comment.
[CHANGES_REQUESTED] Independent cross-review. Concur with Allen's findings.
π΄ Blocking: Partial React major version bump breaks install
CI build failure confirmed β npm ci hits ERESOLVE on Node 18:
While resolving: @types/react-dom@18.3.7
Found: @types/react@19.2.15
Could not resolve dependency:
peer @types/react@"^18.0.0" from @types/react-dom@18.3.7
The PR bumps react and @types/react from 18β19 but leaves their counterparts behind:
react-domstill at^18.3.1(peers onreact@^18)@types/react-domstill at^18.3.6(peers on@types/react@^18.0.0)
This is a Dependabot limitation β it grouped react + @types/react but missed the react-dom + @types/react-dom pair because they're separate packages.
Required fix: Either:
- Bump all four together:
react,react-dom,@types/react,@types/react-domto 19.x, OR - Close this PR and configure Dependabot to group all React packages:
groups: react: patterns: - "react" - "react-dom" - "@types/react" - "@types/react-dom"
useRef requires argument, new JSX transform, etc.). A dedicated migration PR with testing is recommended over an auto-merge Dependabot bump.
lml2468
left a comment
There was a problem hiding this comment.
π΄ [REQUEST_CHANGES β self-review, posting as COMMENT] React 19 is a major breaking upgrade β needs explicit sign-off.
react + @types/react 18.3.x β 19.2.x:
π΄ High-impact breaking change. React 19 removes several APIs that were deprecated in React 18:
ReactDOM.render()β already removed (usecreateRoot)string refsβ removed- Legacy
ContextAPI patterns β changed @types/prop-typesremoved from@types/react(seen in the diff:node_modules/@types/prop-typesdeleted)
π΄ antd 5.24.6 compatibility: antd 5.x officially supports react >=16.9.0 in its peer deps, but real-world React 19 compatibility for antd 5.x is mixed β antd 5 was designed for React 18. The safe upgrade path is antd 5.x + React 18 or antd 6.x + React 19. Current setup uses antd 5.24.6, which may have runtime issues with React 19.
π΅ Recommendation: Either
- Hold this PR and first evaluate upgrading antd to 6.x, then upgrade React to 19 together; or
- Run a full integration test with React 19 + antd 5.24.6 and document results.
Do not merge without explicit team review and test validation.
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together. Updates `react` from 18.3.1 to 19.2.6 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.6/packages/react) Updates `@types/react` from 18.3.28 to 19.2.15 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-version: 19.2.15 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: react dependency-version: 19.2.6 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
88d9877 to
dd2a41b
Compare
Bumps react and @types/react. These dependencies needed to be updated together.
Updates
reactfrom 18.3.1 to 19.2.6Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
eaf3e95Version 19.2.623f4f9f19.2.590ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.15667a41Bump next prerelease version numbers (#34639)8bb7241Bump useEffectEvent to Canary (#34610)e3c9656Ensure Performance Track are Clamped and Don't overlap (#34509)68f00c9Release Activity in Canary (#34374)Updates
@types/reactfrom 18.3.28 to 19.2.15Commits