Skip to content

Remove follow tab unread badge#120

Open
botshen wants to merge 1 commit into
Mininglamp-OSS:mainfrom
dmwork-org:codex/remove-follow-tab-unread
Open

Remove follow tab unread badge#120
botshen wants to merge 1 commit into
Mininglamp-OSS:mainfrom
dmwork-org:codex/remove-follow-tab-unread

Conversation

@botshen
Copy link
Copy Markdown
Contributor

@botshen botshen commented May 25, 2026

Summary

  • Remove the tab-level unread badge from the Follow tab
  • Keep the Recent tab unread badge intact
  • Update SidebarTabBar stories to match the new behavior

Verification

  • pnpm --filter @octo/web build
  • pnpm --filter @octo/web test:storybook -- --run packages/dmworkbase/src/Components/SidebarTabBar/SidebarTabBar.stories.tsx (exits 0; existing Storybook stale-RPC teardown output appears)

Note: full tsc --noEmit still fails on existing unrelated project type errors.

@botshen botshen requested a review from a team as a code owner May 25, 2026 11:06
@github-actions github-actions Bot added the size/M PR size: M label May 25, 2026
Copy link
Copy Markdown
Contributor

@lml2468 lml2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #120 — Remove follow tab unread badge

Verdict: APPROVED

Same content as closed PR #118 (identical SHA 2c9b436). Already reviewed — clean removal of follow tab unread badge, -75 lines of mute-checking logic, Storybook assertions updated. No issues.

See #118 review for full analysis.

Copy link
Copy Markdown
Contributor

@Jerry-Xin Jerry-Xin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: Relevance gate passed; this PR is in scope and cleanly removes the Follow tab-level unread badge while preserving the Recent badge.

💬 Non-blocking

  • 🔵 Suggestion: In packages/dmworkbase/src/Components/SidebarTabBar/SidebarTabBar.stories.tsx:51, the Follow-active story only indirectly verifies the new behavior by checking the Recent badge. Consider also asserting that the first button has no .wk-sidebar-tabbar__badge, so the intended “no Follow tab badge” behavior is guarded explicitly.

✅ Highlights

  • packages/dmworkbase/src/Components/SidebarTabBar/index.tsx:6 updates the public props consistently by removing followUnread.
  • packages/dmworkbase/src/Pages/Chat/index.tsx:89 keeps the Recent unread computation intact, including the existing muted and inactive-group filtering behavior.
  • Repository-wide call-site search found no remaining followUnread usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants