Remove follow tab unread badge#120
Open
botshen wants to merge 1 commit into
Open
Conversation
lml2468
approved these changes
May 25, 2026
Jerry-Xin
approved these changes
May 25, 2026
Contributor
Jerry-Xin
left a comment
There was a problem hiding this comment.
Summary: Relevance gate passed; this PR is in scope and cleanly removes the Follow tab-level unread badge while preserving the Recent badge.
💬 Non-blocking
- 🔵 Suggestion: In
packages/dmworkbase/src/Components/SidebarTabBar/SidebarTabBar.stories.tsx:51, the Follow-active story only indirectly verifies the new behavior by checking the Recent badge. Consider also asserting that the first button has no.wk-sidebar-tabbar__badge, so the intended “no Follow tab badge” behavior is guarded explicitly.
✅ Highlights
packages/dmworkbase/src/Components/SidebarTabBar/index.tsx:6updates the public props consistently by removingfollowUnread.packages/dmworkbase/src/Pages/Chat/index.tsx:89keeps the Recent unread computation intact, including the existing muted and inactive-group filtering behavior.- Repository-wide call-site search found no remaining
followUnreadusage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: full tsc --noEmit still fails on existing unrelated project type errors.