Skip to content

fix(group-chat): create group first when starting group chat from private chat #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a652 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(group-chat): create group first when starting group chat from private chat #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions packages/dmworkcontacts/src/Organizational/GroupNew/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,15 +479,29 @@ export class OrganizationalGroupNew extends Component<
// 添加联系人
if (this.props.action === OrganizationalGroupNewAction.AddMember) {
try {
await WKApp.dataSource.channelDataSource.addSubscribers(
channel,
getOptPersonnelData
);
if (this.props.channel.channelType === ChannelTypePerson) {
// Starting group chat from a private chat:
// must create a new group first, then navigate to it
const uids = [
WKApp.loginInfo.uid || "",
this.props.channel.channelID,
...getOptPersonnelData,
];
const result = await WKApp.dataSource.channelDataSource.createChannel(uids);
if (result?.group_no) {
WKApp.endpoints.showConversation(new Channel(result.group_no, ChannelTypeGroup));
}
} else {
// Adding members to an existing group: original logic
await WKApp.dataSource.channelDataSource.addSubscribers(
channel,
getOptPersonnelData
);
}
} catch (error: any) {
Toast.error(error.msg);
return
return;
}

}
this.onCancel();
}
Expand Down
Loading