Skip to content

Stop one malformed event wedging the indexer forever #179

Closed

Description

@Miracle656

Background

parseEvents (src/decoder.ts:146-163) calls parseEvent in a bare loop with no try/catch. But parseEvent throws — there are six throw new Error("Malformed …") sites at src/decoder.ts:98, 103, 109, 113, 120, 124, and src/__tests__/decoder.test.ts:75-96 asserts that it throws.

Its own docstring at line 143 claims it is "silently skipping unrecognised or malformed ones". It isn't. The throw escapes pollOnce (src/indexer.ts:318) into the loop catch at src/indexer.ts:519-523, which sleeps and retries the identical ledger range forever. One bad event on chain stops indexing permanently, and the only symptom is a repeating log line.

Acceptance criteria

  • parseEvents wraps each parseEvent in try/catch, counts failures, and returns the good records
  • A batch of [good, malformed, good] returns 2 records instead of throwing — fails on main
  • The skipped-decode count is logged distinctly from the existing "non-token events" count
  • parseEvent keeps throwing; only the batch wrapper changes
  • An events_skipped_total{reason} counter in src/metrics.ts

Drips Wave · Complexity: Easy · 100 points


How this repo is laid out

Wraith is a Soroban incoming-transfer indexer: it fills the gap Horizon leaves for SAC/SEP-41 token events by recipient address. Roughly 14k lines under src/, REST + GraphQL + WebSocket, Postgres via Prisma, deployed on Render.

  • Unit tests are jest (src/**/__tests__, tests/*.test.ts), with a coverage gate.
  • Integration tests are vitest (tests/integration/, vitest.integration.config.ts, Docker).
  • Don't mix the two runners in one file.

Known state of main before you start

tsc --noEmit and the unit suite are green. The Integration tests CI job is red, and so is Load test — both predate this batch. Open PRs #177 and #178 address them. If the integration job is red when you open a PR, that is not your fault; say so in the PR and carry on.

Four modules are shipped, closed as done, and imported by nothing: src/indexer/checkpoint.ts, src/ingest/reorg.ts, src/middleware/opa.ts, and src/api/candles.ts + src/workers/ohlc-refresh.ts. So the live indexer today has no reorg handling and no atomic checkpointing, despite both features being closed. Two issues below start unpicking that — don't assume a closed issue means a wired feature.

Ground rules

  • Every PR needs a test that fails before the change and passes after, unless the issue says otherwise.
  • Don't widen a Prometheus label to something unbounded — addresses and contract ids must never become label values.
  • Nothing may log or return a raw database error, a connection string, or a provider URL.
  • Don't reformat a file you're changing. A diff that is 90% whitespace hides the 10% that matters.


Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Activity

  1. Frun1na commented on Sep 24, 2026

    @Frun1na
    Contributor

    @Frun1na has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hello maintainer I would like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Frun1na to this issue.

  2. JemimahEkong commented on Sep 26, 2026

    @JemimahEkong
    Contributor

    @JemimahEkong has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    I can implement the necessary fix. Kindly assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @JemimahEkong to this issue.

  3. drips-wave commented on Sep 26, 2026

    @drips-wave

    Congratulations, @Frun1na! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

    🧑‍💻 @Frun1na: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions