Stop returning raw internal errors to unauthenticated callers #184

Background

The global error handler at src/api.ts:1005-1008 responds with res.status(500).json({ error: err.message }). Prisma and pg errors carry table names, column names and constraint names, and sometimes connection details; src/rpc.ts:277 throws with JSON.stringify(resp) embedded. Any unhandled path hands that to whoever asked.

Acceptance criteria

• 500 responses return a fixed message plus a generated correlation id
• The full error, with that id, is still logged server-side
• Deliberate 4xx responses keep their messages
• A test forcing new Error('relation "token_transfer" does not exist') asserts the body does not contain that text — fails on main

Drips Wave · Complexity: Easy · 100 points

How this repo is laid out

Wraith is a Soroban incoming-transfer indexer: it fills the gap Horizon leaves for SAC/SEP-41 token events by recipient address. Roughly 14k lines under src/, REST + GraphQL + WebSocket, Postgres via Prisma, deployed on Render.

• Unit tests are jest (src/**/__tests__, tests/*.test.ts), with a coverage gate.
• Integration tests are vitest (tests/integration/, vitest.integration.config.ts, Docker).
• Don't mix the two runners in one file.

Known state of main before you start

tsc --noEmit and the unit suite are green. The Integration tests CI job is red, and so is Load test — both predate this batch. Open PRs #177 and #178 address them. If the integration job is red when you open a PR, that is not your fault; say so in the PR and carry on.

Four modules are shipped, closed as done, and imported by nothing: src/indexer/checkpoint.ts, src/ingest/reorg.ts, src/middleware/opa.ts, and src/api/candles.ts + src/workers/ohlc-refresh.ts. So the live indexer today has no reorg handling and no atomic checkpointing, despite both features being closed. Two issues below start unpicking that — don't assume a closed issue means a wired feature.

Ground rules

• Every PR needs a test that fails before the change and passes after, unless the issue says otherwise.
• Don't widen a Prometheus label to something unbounded — addresses and contract ids must never become label values.
• Nothing may log or return a raw database error, a connection string, or a provider URL.
• Don't reformat a file you're changing. A diff that is 90% whitespace hides the 10% that matters.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk