Fix HighChart import error#3
Merged
j4ys0n merged 1 commit intoNov 3, 2025
Merged
Conversation
Root cause: The nicegui-highcharts package does not export a HighChart class. Instead, it extends NiceGUI by adding ui.highchart() to the ui namespace. Changes: - Removed incorrect import: from nicegui_highcharts import HighChart - Changed all HighChart() calls to ui.highchart() - Updated .context/IMPLEMENTATION_FIXES.md to reflect correct usage This fixes the ImportError: cannot import name 'HighChart' from 'nicegui_highcharts' The correct usage is to install nicegui-highcharts (already in pixi.toml), which automatically adds the highchart element to NiceGUI's ui namespace. Tested: - Ruff lint: passed - Python syntax check: passed - Code follows NiceGUI highcharts plugin documentation pattern
There was a problem hiding this comment.
Pull Request Overview
This PR updates the monitor page to use the NiceGUI plugin-based API for Highcharts instead of direct imports. The change migrates from importing nicegui_highcharts.HighChart to using the ui.highchart() method that becomes available after the nicegui-highcharts plugin is installed.
- Removed direct import of
HighChartfromnicegui_highcharts - Replaced all
HighChart()constructor calls withui.highchart()method calls - Updated documentation to reflect the plugin-based approach
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/msquant/app/pages/monitor.py | Migrated from direct HighChart import to plugin-based ui.highchart() API; removed trailing whitespace |
| .context/IMPLEMENTATION_FIXES.md | Updated documentation to reflect plugin-based Highcharts usage and removed references to graceful fallback pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j4ys0n
deleted the
claude/review-msquant-context-011CUkVRVR6GHo7Q6qiPVgfk
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: The nicegui-highcharts package does not export a HighChart class. Instead, it extends NiceGUI by adding ui.highchart() to the ui namespace.
Changes:
This fixes the ImportError:
cannot import name 'HighChart' from 'nicegui_highcharts'
The correct usage is to install nicegui-highcharts (already in pixi.toml), which automatically adds the highchart element to NiceGUI's ui namespace.
Tested: