Skip to content

Refactor tests for analyze_strace_output #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MnemOnicE merged 2 commits into from
Jun 15, 2026
Merged

Refactor tests for analyze_strace_output #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f8c19
Test: refactor analyze_strace_output tests
google-labs-jules[bot] Jun 15, 2026
b4f168c
Update tests/test_main.py
MnemOnicE Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,49 @@ def test_sanitize_text_sentinel_fix(self):
valid_utf8 = "Привет 世界"
self.assertEqual(sanitize_text(valid_utf8), valid_utf8)

def test_analyze_strace_output_realistic(self):
"""Test analyze_strace_output with realistic, full-format multi-line strace output."""
from commando.core.audit import analyze_strace_output

realistic_strace = (
"execve(\"/usr/bin/curl\", [\"curl\", \"https://example.com\"], 0x7ffd5e39d7b0 /* 49 vars */) = 0\n"
"brk(NULL) = 0x55df2b6b5000\n"
"arch_prctl(0x3001 /* ARCH_??? */, 0x7ffeeb9a0d80) = -1 EINVAL (Invalid argument)\n"
"access(\"/etc/ld.so.preload\", R_OK) = -1 ENOENT (No such file or directory)\n"
"openat(AT_FDCWD, \"/etc/ld.so.cache\", O_RDONLY|O_CLOEXEC) = 3\n"
"fstat(3, {st_mode=S_IFREG|0644, st_size=104060, ...}) = 0\n"
"mmap(NULL, 104060, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f2a1b9e2000\n"
"close(3) = 0\n"
"openat(AT_FDCWD, \"/lib/x86_64-linux-gnu/libcurl.so.4\", O_RDONLY|O_CLOEXEC) = 3\n"
"read(3, \"\\177ELF\\2\\1\\1\\0\\0\\0\\0\\0\\0\\0\\0\\0\\3\\0>\\0\\1\\0\\0\\0p\\321\\2\\0\\0\\0\\0\\0\"..., 832) = 832\n"
"fstat(3, {st_mode=S_IFREG|0644, st_size=584608, ...}) = 0\n"
"close(3) = 0\n"
"socket(AF_INET, SOCK_DGRAM|SOCK_CLOEXEC, IPPROTO_IP) = 3\n"
"connect(3, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr(\"8.8.8.8\")}, 16) = 0\n"
"sendto(3, \"\\232\\330\\1\\0\\0\\1\\0\\0\\0\\0\\0\\0\\7example\\3com\\0\\0\\1\\0\\1\", 29, MSG_NOSIGNAL, NULL, 0) = 29\n"
"recvfrom(3, \"\\232\\330\\201\\200\\0\\1\\0\\1\\0\\0\\0\\0\\7example\\3com\\0\\0\\1\\0\\1\\300\\f\"..., 1024, 0, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr(\"8.8.8.8\")}, [28->16]) = 45\n"
"close(3) = 0\n"
"socket(AF_INET, SOCK_STREAM, IPPROTO_TCP) = 3\n"
"connect(3, {sa_family=AF_INET, sin_port=htons(443), sin_addr=inet_addr(\"93.184.216.34\")}, 16) = -1 EINPROGRESS (Operation now in progress)\n"
"write(1, \"<html>\\n<body>\\n<h1>Example Domain\"..., 1256) = 1256\n"
)
Comment on lines +106 to +127

@gemini-code-assist gemini-code-assist Bot Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to PEP 8, when a string contains double quote characters, you should use single quotes for the outer string literal to avoid backslash escapes. This significantly improves readability.

        realistic_strace = (
            'execve("/usr/bin/curl", ["curl", "https://example.com"], 0x7ffd5e39d7b0 /* 49 vars */) = 0\n'
            'brk(NULL)                               = 0x55df2b6b5000\n'
            'arch_prctl(0x3001 /* ARCH_??? */, 0x7ffeeb9a0d80) = -1 EINVAL (Invalid argument)\n'
            'access("/etc/ld.so.preload", R_OK)      = -1 ENOENT (No such file or directory)\n'
            'openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3\n'
            'fstat(3, {st_mode=S_IFREG|0644, st_size=104060, ...}) = 0\n'
            'mmap(NULL, 104060, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f2a1b9e2000\n'
            'close(3)                                = 0\n'
            'openat(AT_FDCWD, "/lib/x86_64-linux-gnu/libcurl.so.4", O_RDONLY|O_CLOEXEC) = 3\n'
            'read(3, "\\177ELF\\2\\1\\1\\0\\0\\0\\0\\0\\0\\0\\0\\0\\3\\0>\\0\\1\\0\\0\\0p\\321\\2\\0\\0\\0\\0\\0"..., 832) = 832\n'
            'fstat(3, {st_mode=S_IFREG|0644, st_size=584608, ...}) = 0\n'
            'close(3)                                = 0\n'
            'socket(AF_INET, SOCK_DGRAM|SOCK_CLOEXEC, IPPROTO_IP) = 3\n'
            'connect(3, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("8.8.8.8")}, 16) = 0\n'
            'sendto(3, "\\232\\330\\1\\0\\0\\1\\0\\0\\0\\0\\0\\0\\7example\\3com\\0\\0\\1\\0\\1", 29, MSG_NOSIGNAL, NULL, 0) = 29\n'
            'recvfrom(3, "\\232\\330\\201\\200\\0\\1\\0\\1\\0\\0\\0\\0\\7example\\3com\\0\\0\\1\\0\\1\\300\\f"..., 1024, 0, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("8.8.8.8")}, [28->16]) = 45\n'
            'close(3)                                = 0\n'
            'socket(AF_INET, SOCK_STREAM, IPPROTO_TCP) = 3\n'
            'connect(3, {sa_family=AF_INET, sin_port=htons(443), sin_addr=inet_addr("93.184.216.34")}, 16) = -1 EINPROGRESS (Operation now in progress)\n'
            'write(1, "<html>\\n<body>\\n<h1>Example Domain"..., 1256) = 1256\n'
        )
References
  1. PEP 8 recommends using the other quote character (single vs double) to avoid backslashes in the string when a string contains quote characters. (link)


tags = analyze_strace_output(realistic_strace)

self.assertCountEqual(
tags,
["[Process Spawner]", "[File Reader/Writer]", "[Network Mutator]"]
)

# Test deduplication - output with many openat but only one tag expected
dedup_strace = (
'openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3\n'
'openat(AT_FDCWD, "/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY|O_CLOEXEC) = 3\n'
'openat(AT_FDCWD, "/usr/lib/locale/locale-archive", O_RDONLY|O_CLOEXEC) = 3\n'
)
Comment thread
MnemOnicE marked this conversation as resolved.
tags_dedup = analyze_strace_output(dedup_strace)
self.assertCountEqual(tags_dedup, ["[File Reader/Writer]"])

@patch("subprocess.run")
def test_subprocess_mocking(self, mock_run):
"""Fortify Test Suite: Mock the subprocess.run calls to deterministically test logic."""
Expand Down
Loading