feat(api): forward inbound messages — /messages/{id}/forward across SDKs, CLI, MCP#171
Merged
Conversation
…CLI/MCP
Mirrors the existing reply path: handler validates ownership, applies
HITL/idempotency/rate-limit/domain checks, then composes via new
outbound.BuildForward{Subject,Body,HTMLBody} helpers — best-effort MIME
extraction of the original body, Gmail-style header block, no
In-Reply-To/References (forwards are new threads).
HITL fix: buildSendRequestFromMessage now only copies email_message_id
into ReplyToMessageID when type="reply", so approved forwards don't
accidentally stitch into the original thread on send.
Includes:
- migration 019 extending messages.message_type CHECK with 'forward'
- TS SDK forwardMessage in api/client/inbound-email
- CLI: e2a forward <msg-id> --to … [--body …]
- MCP: forward_message tool
- Compile fix on a pre-existing internal/e2e mismatch where local
structs declared To as string instead of []string
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ests
Review follow-ups:
1. BuildForwardBody mangled CRLF input. The naive ReplaceAll("\n","\r\n")
turned existing "\r\n" into "\r\r\n", which renders as a literal CR
in some clients. Most real inbound bodies arrive CRLF-terminated, so
the bug would fire on virtually every multi-line forward.
Fix: normalize "\r\n" → "\n" first, then convert to "\r\n".
2. performSelfSend hardcoded message_type="send" for the loopback row.
Pre-existing latent bug — self-replies also recorded as "send".
Fix: thread msgType through; all three callers (send/reply/forward)
now record their actual intent.
3. Add the 4 integration tests the review called out:
- TestForwardMessageSelfForwardUsesLoopback (loopback path coverage)
- TestForwardMessageHTMLAtSMTP (multipart/alternative at the wire)
- TestForwardMessageWithAttachments (caller-supplied attachment passthrough)
- TestForwardMessageIdempotentReplay (Idempotency-Key replay shape)
4. Add 2 CRLF regression tests on BuildForwardBody (both CRLF and LF-only
inputs must emit clean CRLF, never "\r\r\n").
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jiashuoz
force-pushed
the
feat/forward-message-api
branch
from
0dd179c to
cd50568
Compare
This was referenced May 28, 2026
jiashuoz
added a commit
that referenced
this pull request
May 28, 2026
Closes the parity gap from PR #171 (Forward feature). TS SDK, CLI, and MCP shipped with Forward; the Python SDK didn't. Adds matching surface to both sync and async variants. Raw (api.py / async_client.py): - forward_message(agent_email, message_id, body: ForwardMessageRequest, idempotency_key) → SendEmailResponse High-level (client.py / async_client.py): - forward(message_id, to, body=None, html_body=None, cc=None, bcc=None, conversation_id=None, attachments=None, agent_email=None, idempotency_key=None) → SendResult Builds the ForwardMessageRequest from kwargs, base64-encodes attachments via the existing _serialize_attachments helper, returns the SendResult dataclass — same shape callers already use for reply() and send(). Tests (+5): - api.py: POST /forward with Idempotency-Key header threaded through - client.py: high-level forward() returns SendResult; attachments + conversation_id round-trip correctly through the wire - async_client.py: async high-level forward() smoke test 202 tests pass (was 197). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jiashuoz
added a commit
that referenced
this pull request
May 28, 2026
Adds .github/pull_request_template.md as a forcing function against the parity gap we hit on #171 (Forward shipped to Go/TS/CLI/MCP but missed Python; needed #175 to close). The template surfaces the full client matrix (Go, TS SDK, Python SDK sync+async, CLI, MCP) plus migration safety, generated-types refresh, and a per-surface tests row. GitHub auto-fills this on `gh pr create` and the web "New PR" form, so it's free to author and free to enforce. Rows are individually deletable for PRs that don't touch the API or any client. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Forward endpoint mirroring the existing Reply path:
POST /api/v1/agents/{email}/messages/{id}/forward.Surfaces shipped
What's NOT in scope (deferred)
Test plan
Pre-existing failures NOT caused by this PR:
🤖 Generated with Claude Code