fix: remove social login queryString - #39
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughOAuth 로그인 성공 시 토큰을 URL에 포함하지 않고 직접 리다이렉트하며, 프론트엔드는 HttpOnly Refresh Cookie로 세션을 확인합니다. 소셜 로그인은 OAuth 경로로 즉시 이동하고, Vite 프록시 경로가 구체화되었습니다. ChangesOAuth 쿠키 인증 흐름
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant LoginPage
participant OAuthProvider
participant OAuth2LoginSuccessHandler
participant App
User->>LoginPage: 소셜 로그인 선택
LoginPage->>OAuthProvider: OAuth 인증 시작
OAuthProvider->>OAuth2LoginSuccessHandler: 인증 콜백
OAuth2LoginSuccessHandler->>App: 토큰 없는 redirectUrl 리다이렉트
App->>App: Refresh Cookie로 /api/auth/refresh 호출
App->>App: /api/users/me 호출
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@momogo-api/src/main/java/com/momogo/api/auth/handler/OAuth2LoginSuccessHandler.java`:
- Around line 71-72: OAuth2LoginSuccessHandler의 Javadoc에서 더 이상 사용하지 않는 token 쿼리
파라미터 전달 설명을 제거하세요. Access Token을 URL에 포함하지 않고 Refresh Cookie 발급 후 프론트엔드로 리다이렉트하는
현재 동작을 설명하도록 해당 문서를 갱신하고, 구현부의 response.sendRedirect 흐름은 변경하지 마세요.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 293b939d-8fad-4fec-abb7-e2d33e5c54de
📒 Files selected for processing (4)
momogo-api/src/main/java/com/momogo/api/auth/handler/OAuth2LoginSuccessHandler.javamomogo-frontend/src/App.tsxmomogo-frontend/src/pages/LoginPage.tsxmomogo-frontend/vite.config.ts
작업 내용
변경 사항
체크리스트
참고 사항
관련 이슈
Summary by CodeRabbit
새로운 기능
버그 수정