-
Notifications
You must be signed in to change notification settings - Fork 1
feat: send periodic heartbeat to keep notification SSE connections alive #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
...rc/main/java/com/momogo/api/notification/scheduler/NotificationSseHeartbeatScheduler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package com.momogo.api.notification.scheduler; | ||
|
|
||
| import com.momogo.api.notification.registry.NotificationEmitterRegistry; | ||
| import java.io.IOException; | ||
| import lombok.RequiredArgsConstructor; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.scheduling.annotation.Scheduled; | ||
| import org.springframework.stereotype.Component; | ||
| import org.springframework.web.servlet.mvc.method.annotation.SseEmitter; | ||
|
|
||
| /* | ||
| * SSE 연결이 오래 idle 상태면 중간 프록시/로드밸런서가 죽은 연결로 오해해 끊어버릴 수 있음 | ||
| * 일정 주기로 빈 코멘트를 보내 연결이 살아있음을 알림 | ||
| */ | ||
| @Slf4j | ||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class NotificationSseHeartbeatScheduler { | ||
|
|
||
| private static final long HEARTBEAT_INTERVAL = 30_000L; // 30초 | ||
|
|
||
| private final NotificationEmitterRegistry emitterRegistry; | ||
|
|
||
| @Scheduled(fixedRate = HEARTBEAT_INTERVAL) | ||
| public void sendHeartbeat() { | ||
| for (SseEmitter emitter : emitterRegistry.findAll()) { | ||
| try { | ||
| emitter.send(SseEmitter.event().comment("heartbeat")); | ||
| } catch (IOException | IllegalStateException e) { | ||
| log.warn("[NotificationSseHeartbeatScheduler] 하트비트 전송 실패, 연결 정리", e); | ||
| emitter.completeWithError(e); | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.