Locate shipyard through shipyard-cmake, not the CMake user package registry - #4
Merged
Merged
Conversation
…kage registry shipyard's pkg postinstall no longer writes the CMake user package registry and nothing reads it. build/msc.sh is resynced from shipyard's canonical template, which asks shipyard-cmake where find_package(MavericksShipyard) lands instead of reading ~/.cmake/packages, and also exports SHIPYARD_SCRIPTS (which shipyard's msc_scripts() now requires). Nothing else in this repo touches the mechanism: it has no CMakeLists.txt, no find_package(MavericksShipyard) and no cmake/ctest/cpack call site. BREAKING CHANGE: needs shipyard's shipyard-cmake on PATH (install@v1 provides it). Do not merge until shipyard has landed bc3082a. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTxFde2TJMmp5p64DhvDSK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the 14-repo shipyard CMake flag day. Do not merge until shipyard has landed bc3082a.
build/msc.shresynced byte-for-byte from shipyard's canonicalscripts/templates/msc.sh(blob
43c2af0). It probesshipyard-cmakeinstead of reading~/.cmake/packages/, and exportsSHIPYARD_SCRIPTS, which shipyard'smsc_scripts()now requires.No workflow step was added:
install@v1's default mode already putsshipyard-cmakeonPATH.Insulation confirmed
Swept every tracked file with no path filter (the conventions gate cannot see
*.bats,tests/*.sh,extensionless executables,
*.cmakeorCMakeLists.txt): this repo has noCMakeLists.txt, nofind_package(MavericksShipyard), no registry read outsidemsc.sh, and nocmake/ctest/cpackcall site anywhere — including in prose.
msc.shwas the whole surface.tests/*'s${SHIPYARD_SCRIPTS:-$R/../mavericks-shipyard/scripts}sibling fallback is a plain pathdefault, not a registry read and not a
cmake --installbootstrap, so it survives the cutoveruntouched.
Conventions gate (from shipyard
bc3082a): 2 failures ->ok, exit 0.check-shell-portabilityok,
check-commentsexit 0,sh -nclean, andtests/{skeleton,renovate,workflow,fetch-ed25519}.shall exit 0 (
build-tools.sh/package-pkg.shskip 77 on a 10.9 host, as designed).🤖 Generated with Claude Code
https://claude.ai/code/session_01GTxFde2TJMmp5p64DhvDSK