fix: correct bitwise-eqv to return integer instead of boolean#465
Merged
da-liii merged 2 commits intoMoganLab:mainfrom Feb 25, 2026
Merged
fix: correct bitwise-eqv to return integer instead of boolean#465da-liii merged 2 commits intoMoganLab:mainfrom
da-liii merged 2 commits intoMoganLab:mainfrom
Conversation
Contributor
|
please update https://github.com/MoganLab/goldfish/blob/main/tests/goldfish/liii/bitwise-test.scm accordingly |
Contributor
Author
|
@da-liii I have updated the tests. Lemme know if there is anything else changes or updation needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue?
Fixes #90
The current implementation of
bitwise-eqvinsrfi-151.scmreturns a boolean (
#tor#f) instead of an integer, whichis incorrect according to the SRFI 151 standard.
What was changed?
goldfish/srfi/srfi-151.scmBefore:
(define (bitwise-eqv a b)
(= (bitwise-xor a b) 0))
After:
(define (bitwise-eqv a b)
(bitwise-not (bitwise-xor a b)))
Why?
SRFI 151 specifies that
bitwise-eqvshould return an integer(bitwise XNOR), not a boolean equality check.