Skip to content

Test/fold multi list issue 190#467

Closed
aadiexii wants to merge 3 commits intoMoganLab:mainfrom
aadiexii:test/fold-multi-list-issue-190
Closed

Test/fold multi list issue 190#467
aadiexii wants to merge 3 commits intoMoganLab:mainfrom
aadiexii:test/fold-multi-list-issue-190

Conversation

@aadiexii
Copy link
Contributor

Closes #190

What is the issue?
Issue #190 reported that fold and fold-right should accept a variable number of lists per the SRFI 1 specification.

What was found?
The multi-list support for fold and fold-right has already been implemented in the current codebase (the definitions use rest args . lists and handle both single and multi-list cases). The issue referenced an older commit (43bb071) where this was not yet the case.

What was changed?
Added the canonical SRFI 1 spec examples and additional edge-case tests to
tests/goldfish/liii/list-test.scm:

(fold cons* '() '(a b c) '(1 2 3 4 5)) — SRFI 1 spec example
(fold-right cons* '() '(a b c) '(1 2 3 4 5)) — SRFI 1 spec example
Three-list fold, single-element lists, and empty-list edge cases

image

@da-liii
Copy link
Contributor

da-liii commented Feb 25, 2026

Thanks for the second pull request. Well, you need to learn more git skills.

For the second pull request, you should have created a new branch based on the main branch.

@aadiexii
Copy link
Contributor Author

Hey @da-liii
Sorry, I created the branch from the wrong base earlier. I’ve opened a clean PR from main now.

@aadiexii aadiexii closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: SRFI 1 fold and fold-right

2 participants