test: add SRFI 1 spec examples for multi-list fold and fold-right#470
Open
aadiexii wants to merge 1 commit intoMoganLab:mainfrom
Open
test: add SRFI 1 spec examples for multi-list fold and fold-right#470aadiexii wants to merge 1 commit intoMoganLab:mainfrom
aadiexii wants to merge 1 commit intoMoganLab:mainfrom
Conversation
Contributor
Author
|
Hey @da-liii Can you checkout this and lemme know if this need any improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190
What is the issue?
Issue #190 reported that fold and fold-right should accept a variable number of lists per the SRFI 1 specification.
What was found?
The multi-list support for fold and fold-right has already been implemented in the current codebase (the definitions use rest args . lists and handle both single and multi-list cases). The issue referenced an older commit (43bb071) where this was not yet the case.
What was changed?
Added the canonical SRFI 1 spec examples and additional edge-case tests to
tests/goldfish/liii/list-test.scm:
(fold cons* '() '(a b c) '(1 2 3 4 5)) — SRFI 1 spec example
(fold-right cons* '() '(a b c) '(1 2 3 4 5)) — SRFI 1 spec example
Three-list fold, single-element lists, and empty-list edge cases