Initial support for R7RS environment#15
Merged
ufo5260987423 merged 4 commits intoMoganLab:mainfrom Jul 1, 2025
Merged
Conversation
- Modified `analysis/workspace.sls` to enhance the `init-workspace` function by adding a `top-environment` parameter, enabling differentiation between R6RS and R7RS environments. - Introduced R7RS test code, placed under the `tests/r7rs/` directory. - Added `analysis/package-manager/txt-filter.sls` as a temporary solution. This file uses a straightforward approach to filter all `.txt` files. Since R7RS-related tests require R7RS code, the relevant code has been placed in the `tests/r7rs/` directory and renamed to `.scm.txt`. - Added `tests/analysis/test-r7rs-workspace.sps`, which mimics `tests/analysis/test-workspace.sps`. This file includes a simple test to verify that the workspace functions correctly when `top-environment` is set to R7RS.
- Updated `analysis/workspace.sls` to ensure the `init-workspace` function properly handles the 4-parameter case in its `case-lambda`. - Commented out several `pretty-print` statements previously used for debugging.
Collaborator
There was a problem hiding this comment.
Maybe this test should be done in test-workspace.sps?
Collaborator
|
the files in test/r7rs should be moved to test/resources/r7rs |
- Moved the tests from `tests/analysis/test-r7rs-workspace.sps` into `tests/analysis/test-workspace.sps` and deleted the `test-r7rs-workspace.sps` file. - Relocated files from `test/r7rs` to `test/resources/r7rs` directory for better organization.
Collaborator
Author
|
Thank you for your feedback and guidance. I have made the following changes:
|
… analysis/workspace.sls.
Collaborator
Author
|
Adjusted some indentation in the init-workspace function in analysis/workspace.sls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analysis/workspace.slsby modifying theinit-workspacefunction to include atop-environmentparameter, enabling differentiation between R6RS and R7RS environments.tests/r7rs/directory.analysis/package-manager/txt-filter.slsas a temporary solution to filter.txtfiles. This is necessary for R7RS-related tests, which require R7RS code placed in thetests/r7rs/directory and renamed to.scm.txt.tests/analysis/test-r7rs-workspace.sps, mimickingtests/analysis/test-workspace.sps, to verify that the workspace functions correctly whentop-environmentis set to R7RS.