Prepare scale-reference for open source - #1
Merged
Merged
Conversation
Fixes found in the pre-publish review, and what a public package needs.
Fixes:
- The UK £1 was listed at 23.03 mm; the Royal Mint gives 23.43 mm. It is
12-sided and the 20p is seven-sided, so an ellipse fit does not match
them exactly: both are now `exact: false`. The round coins are unchanged.
- Default reference entries were shared objects: changing one diameter
changed it for the whole app. Each entry is frozen now.
- Neutral wording ("square to the subject").
Public-package pieces:
- README rewritten: millimetres are estimates, not measurements, and are
not validated for clinical use; a Limits section lists the error sources
(height difference, tilt, lens distortion, detection, shape); the
reference table with sizes and `exact`.
- CONTRIBUTING (the estimate-not-measurement rule, how to add a reference
with its source), CODE_OF_CONDUCT, SECURITY for a public repository.
- publishConfig.access public; neutral keywords.
- CI (Node 20 and 22, tarball file check) and a release workflow that
publishes with npm trusted publishing. Actions pinned by commit SHA.
Tests: 19 (was 17); both new cases fail on the old table.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the three packages going public (photo-quality, scale-reference, health-data). This PR does not change the repository's visibility and does not publish anything.
Fixes from the pre-publish review
exact, but an ellipse fit doesn't match a polygon exactly.exact: false. The round coins and the sticker are unchanged.getConfig()copied the catalog, but the entries were shared objects, so changing one diameter changed it for the whole app.exactisn't read anywhere in the code, and the MoleCare app only usesSTICKER_10MM, so nothing in the app changes.What a public package needs
exact.publishConfig.access: publicand neutral keywords.How it was checked
Before the first release (needs the owner)
Same as photo-quality:
molecare.npm publish --access publicfrom a clean checkout.MoleCare/rn-scale-reference/release.yml/ environmentnpm.🤖 Generated with Claude Code