Add thread-safe storage - #41
Merged
Merged
Conversation
somasekimoto
changed the title
somasekimoto
changed the title
- Replace RefCell with Mutex in SharedLeveldb for thread safety - Replace Rc with Arc for shared ownership across threads - Add Send + Sync bounds to OperationStorage and NodeStorage traits - Update all storage implementations to use Mutex::lock() - Add LockPoisoned variant to BatchError for proper error handling - Update test mocks (MockStorage, MemoryNodeStorage) to use Arc<Mutex> - Update FailingOperationStorage/FailingNodeStorage to use AtomicBool This enables crsl-lib to be safely used in async/await environments and multi-threaded contexts.
Member
|
ありがとうございます！！！ |
Yu-da-1
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LeveldbStorage,LeveldbNodeStorage）をRefCellからMutexに変更してスレッドセーフ化OperationStorage/NodeStorageトレイトにSend + Sync制約を追加MemoryNodeStorage/MockStorageもMutexベースに更新Test plan
cargo testが通ることを確認cargo clippyでエラーがないことを確認🤖 Generated with Claude Code