Skip to content

refactor: reuse ContentId generation #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xkenta merged 2 commits into from
Sep 14, 2026
Merged

refactor: reuse ContentId generation #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c49b53
refactor: reuse ContentId generation
0xkenta Sep 5, 2026
5a24fdf
fix: remove unused node hashing symbols
0xkenta Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions src/dasl/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
use super::cid::ContentId;
use super::error::{DaslError, NodeValidationError, Result};
use cid::Cid;
use multihash::Multihash;
use serde::{Deserialize, Serialize};
use sha2::{Digest, Sha256};
use std::collections::BTreeMap;

/// For more details on these multicodec codes, see:
/// https://github.com/multiformats/multicodec/blob/master/table.csv
const SHA2_256_CODE: u64 = 0x12;
const RAW_CODE: u64 = 0x55;

/// This structure can store any type of payload data and metadata, making it versatile for various use cases.
///
/// # Type Parameters
Expand Down Expand Up @@ -75,9 +69,7 @@ where
/// Returns a NodeError if serialization or hashing fails
pub fn content_id(&self) -> Result<Cid> {
let buf = self.to_bytes()?;
let hash = Sha256::digest(&buf);
let mh = Multihash::<64>::wrap(SHA2_256_CODE, &hash)?;
Ok(Cid::new_v1(RAW_CODE, mh))
Ok(ContentId::new(&buf)?.0)
}

/// Serializes this node using CBOR
Expand Down Expand Up @@ -155,13 +147,10 @@ where
#[cfg(test)]
mod tests {
use super::*;
use sha2::{Digest, Sha256};
use std::collections::BTreeMap;

fn create_test_content_id(data: &[u8]) -> Cid {
let hash = Sha256::digest(data);
let digest = Multihash::<64>::wrap(SHA2_256_CODE, &hash).unwrap();
Cid::new_v1(RAW_CODE, digest)
ContentId::new(data).unwrap().0
}

#[test]
Expand Down
Loading