Revert MDBX FFI C# binding and entry type update changes#4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts prior changes to the mdbx-ffi UniFFI surface by reintroducing a guard that prevents update_entry from mutating an entry’s type, and by removing the C# UniFFI binding configuration and generation script.
Changes:
- Restores
update_entrybehavior to reject entry-type changes (constraint violation if the requested type doesn’t match the stored type). - Removes C# binding artifacts (
uniffi.tomland PowerShell generation script) and trims the exposed FFI API accordingly. - Updates lockfile/dependency graph (notably via the UniFFI version change in
mdbx-ffi).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/generate-csharp-bindings.ps1 | Removed PowerShell script used to generate C# UniFFI bindings. |
| crates/mdbx-ffi/uniffi.toml | Removed C# UniFFI bindings configuration. |
| crates/mdbx-ffi/tests/ffi_smoke.rs | Removes attachment and entry-type-mutation assertions; keeps generic smoke coverage. |
| crates/mdbx-ffi/src/lib.rs | Removes attachment/project-list APIs and enforces “no entry type changes” in update_entry. |
| crates/mdbx-ffi/Cargo.toml | Changes UniFFI dependency version requirement. |
| Cargo.lock | Reflects dependency resolution changes (UniFFI and transitive updates). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
17
| mdbx-core = { path = "../mdbx-core" } | ||
| mdbx-storage = { path = "../mdbx-storage" } | ||
| serde_json = { workspace = true } | ||
| thiserror = { workspace = true } | ||
| uniffi = "=0.29.4" | ||
| uniffi = "0.31.1" | ||
| zeroize = { workspace = true } |
Comment on lines
157
to
159
| vault | ||
| .delete_entry(source.project_id.clone(), created.entry_id.clone()) | ||
| .unwrap(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e90ab65dc7220c36328c535aac114730c0240d56to restore the MDBX FFI guard that preventsupdate_entryfrom changing an entry's type.fdf33827bbe44c6c29ae3abf0ac9646803aca00f, removing the C# UniFFI binding exposure,uniffi.toml, and the PowerShell binding generation script.mdbx-ffidependency/version surface and smoke test coverage.Test Plan
cargo test -p mdbx-ffi