Real Traits#3434
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
* why * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci (cherry picked from commit 96304b787bc69dc51ceffa191ff770554888dbd6)
HasTraitCondition instead of Conflicts and Requirements RemoveBodyPartEffect instead of AmputeeComponent/System Remove redundant BorgChassis checks Remove failed condition check and just show the full one Improve vision trait conditions
|
As far as I can see, the problems of the previous PR review have been fixed and are ready for new review. |
|
Waiting for review day 1 |
OneZerooo0
left a comment
OneZerooo0
left a comment
There was a problem hiding this comment.
Disabilities should give points rather than cost them
Negative/positive points should be reversed (traits that currently "add" points should say they remove them instead, since thats what they functionally do)
Not sure which of the perks that currently give points are supposed to take them away, but the ones that used to take points for making the game harder now give points instead. |
|
Waiting for new review day 1 |
|
Waiting for review day 3 |
What I mean is that when a trait that says it decreases the amount of points taken is taken, it instead increases available points - while I can see how it could be argued that its negative point cost, its really weird/unclear when you also have traits that "give" points |
Redrover1760
left a comment
Redrover1760
left a comment
There was a problem hiding this comment.
Trait UI selection doesn't seem to work, clicking on traits does nothing. I tried fresh and old characters too and neither seemed to work.
Amputee, Blindness, Numb, Short-sided etc all seem to take points for some reason instead of give them, weirdly enough.
|
wait what |
|
fell for it again award |
|
Ok, the trait checkboxes when unchecked are just very very hard to see, and clicking on the trait itself doesn't do anything, you have to click on the checkbox ah |
|
Checkboxes are also very hard to see, please make them more clear |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
I remember about this PR, but I have a lot of other work. I'll come back to it when I'm free. |
5 participants
About the PR
Continued PR #3153
Ports the new "real trait" system from Delta V Existing traits were migrated to the new system. Numbers and groupings may still need adjustments, up to Monolith staff.
Why / Balance
Was requested.
How to test
Make characters, see if they spawn in right, and if the conditions are being checked correctly.
Media
Requirements
Breaking changes
TraitPrototype has been wholesale replaced The included migration will reset the traits table in the database.
Changelog 🆑 MilonPL, Toby222, Lokilife