Project/Anim: Implement AnimPLayerSimple#1178
Draft
german77 wants to merge 3 commits into
Draft
Conversation
github-actions
Bot
added
the
status:waiting for review
MonsterDruide1
added
status:blocked
german77
force-pushed
the
AnimPlayerSimple
branch
from
878ca73 to
1b7c4f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class is not simple in the slightest. I had to scratch quite a few other objects to get enough info of the members of this object. I believe this is correct but it might not be a
BoneVisibilityAnimObjI can't fully confirm this member until I implement the children of this class.Besides that is fully matching but not ready for review. It depends on #1127 and nn changes. I just oppened this early so others can somewhat verify the PR on nn.
This change is
Report for 1.0 (5dfa7a6 - 1b7c4f4)
📈 Matched code: 15.14% (+0.02%, +1952 bytes)
✅ 25 new matches
Project/Anim/AnimInfoal::AnimInfoTable::sort()Project/Anim/AnimInfoal::AnimInfoTable::findAnimInfo(char const*) constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::calcNeedUpdateAnimNext()Project/Anim/AnimInfoal::AnimInfoTable::AnimInfoTable(int)Project/Anim/AnimInfoal::AnimInfoTable::add(char const*, void*, float, bool)Project/Anim/AnimPlayerSimpleal::AnimPlayerSimple::startAnim(char const*)Project/Anim/AnimPlayerSimpleal::AnimPlayerSimple::setAnimFrame(float)Project/Anim/AnimPlayerSimpleal::AnimPlayerSimple::update()Project/Anim/AnimPlayerSimpleal::AnimPlayerSimple::AnimPlayerSimple()Project/Anim/AnimPlayerSimpleal::AnimPlayerSimple::setAnimFrameRate(float)Project/Anim/AnimPlayerSimpleal::AnimPlayerSimple::applyTo()Project/Anim/AnimPlayerSimpleal::AnimPlayerSimple::isAnimEnd() constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::isAnimOneTime() constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::isAnimOneTime(char const*) constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::isAnimExist(char const*) constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::getAnimFrameMax(char const*) constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::getPlayingAnimName() constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::clearAnim()Project/Anim/AnimPlayerSimpleal::AnimPlayerSimple::getAnimFrame() constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::getAnimFrameMax() constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::getAnimFrameRate() constProject/Anim/AnimPlayerSimpleal::AnimPlayerSimple::isAnimPlaying() constProject/Anim/AnimInfoal::AnimResInfo::AnimResInfo()Project/Anim/AnimInfoal::AnimResInfo::getFrameMax() constProject/Anim/AnimInfoal::AnimResInfo::isLoop() const📈 1 improvement in an unmatched item
Project/Anim/AnimInfoal::AnimInfoTable::tryFindAnimInfo(char const*) const