-
-
Notifications
You must be signed in to change notification settings - Fork 119
Fix URL-encoded changelog in nightly release notes #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 📝 WalkthroughWalkthroughModified the nightly workflow to output changelog to a file named CHANGELOG_NIGHTLY.md and updated the release step to reference this file instead of embedding changelog content inline. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
… encoded output Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
|
The nightly workflow ( |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/nightly.yml (1)
35-46: Action reference appears invalid—andelf/nightly-releasedoes not exist on GitHub.The workflow logic is otherwise sound:
CHANGELOG_NIGHTLY.mdis correctly generated in step 1 and used in step 2. However, the actionandelf/nightly-release@maincannot be verified to exist in any public GitHub repository. This would cause the workflow to fail when attempting to run.Verify the correct action name or consider using an alternative release action like
softprops/action-gh-releaseoractions/create-release, both of which supportbody_pathparameter and are well-documented.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/nightly.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: wled_build / Builds (esp32_4MB_V4_S_eth)
- GitHub Check: wled_build / Builds (esp32c3dev_2MB_M)
- GitHub Check: wled_build / Builds (esp32S3_8MB_PSRAM_M)
- GitHub Check: wled_build / Builds (esp8266_4MB_S)
- GitHub Check: wled_build / Builds (esp8266_4MB_M)
- GitHub Check: wled_build / Builds (esp32S3_8MB_S)
- GitHub Check: wled_build / Builds (esp32s2_PSRAM_M)
- GitHub Check: wled_build / Builds (esp32S3_4MB_PSRAM_S)
- GitHub Check: wled_build / Builds (athom_music_esp32_4MB_V4_M)
- GitHub Check: wled_build / Builds (esp8266_2MB_S)
- GitHub Check: wled_build / Builds (esp32S3_4MB_PSRAM_M)
- GitHub Check: wled_build / Builds (esp32_16MB_V4_S)
- GitHub Check: wled_build / Builds (esp32S3_4MB_S)
- GitHub Check: wled_build / Builds (esp32S3_WROOM-2_M)
- GitHub Check: wled_build / Builds (esp32_4MB_PSRAM_S)
- GitHub Check: wled_build / Builds (esp32_16MB_V4_M_debug)
- GitHub Check: wled_build / Builds (esp32_4MB_M_eth)
- GitHub Check: wled_build / Builds (esp32S3_16MB_PSRAM_M_HUB75)
- GitHub Check: wled_build / Builds (esp32_4MB_V4_S_HUB75)
- GitHub Check: wled_build / Builds (esp32_pico_4MB_V4_S)
🔇 Additional comments (1)
.github/workflows/nightly.yml (1)
26-34: Theoutputparameter is not supported by this action.The
janheinrichmerker/action-github-changelog-generator@v2.4action does not have anoutputparameter. Supported inputs are:repo,user,project,token,securityLabel,securityLabels,issuesLabel,prLabel,onlyLastTag,stripHeaders, andstripGeneratorNotice. The action only provides a single output:changelog(the changelog content as a string).The code shown uses both unsupported parameters:
output: CHANGELOG_NIGHTLY.mdandsinceTag: v14.7.1. These will either be silently ignored or cause the action to fail. To achieve the goal of writing the changelog to a file, you would need to use a separate step that writes the${{ steps.changelog.outputs.changelog }}output to a file, rather than relying on a non-existentoutputparameter.Likely an incorrect or invalid review comment.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
|
@copilot github checks performed on this PR now show a different name than before, like |
The GitHub check naming you're observing ("WLED CI /wled_build / ") is not related to my changes. I only modified |
@coderabbitai please double-check this finding. The workflow seems to finish without error in the |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1600 🏁 Script executed: Length of output: 167 🏁 Script executed: Length of output: 2 🏁 Script executed: Length of output: 1251 🏁 Script executed: Length of output: 1085 🏁 Script executed: Length of output: 1085 🏁 Script executed: Length of output: 1110
✅ The ✅ The body_path:
description: "Path to load note-worthy description of changes in release from"
required: false✅ The workflow is working correctly - Recent workflow runs show consistent success on the main branch, confirming the action functions as expected. The workflow implementation in this PR is correct: generating |
Nightly release notes display URL-encoded text (
%0A,%0D,%25) instead of formatted markdown. The changelog generator action outputs URL-encoded multiline content per GitHub Actions spec, butandelf/nightly-releasedoesn't decode it when passed via thebodyparameter.Changes
body_pathparameter to read unencoded file content- name: "✏️ Generate release changelog" uses: janheinrichmerker/action-github-changelog-generator@v2.4 with: token: ${{ secrets.GITHUB_TOKEN }} sinceTag: v14.7.1 + output: CHANGELOG_NIGHTLY.md excludeLabels: 'stale,wontfix,duplicate,invalid' - name: Update Nightly Release uses: andelf/nightly-release@main with: tag_name: nightly name: 'Nightly mdev Build $$' prerelease: true - body: ${{ steps.changelog.outputs.changelog }} + body_path: CHANGELOG_NIGHTLY.mdOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.