Skip to content

improve audio track selection#100

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
harleykradovill:audio
May 26, 2026
Merged

improve audio track selection#100
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
harleykradovill:audio

Conversation

@harleykradovill
Copy link
Copy Markdown
Collaborator

Pull Request

Summary

This PR improves audio track selection persistence by retaining the user's selected audio stream index on an item when navigating between the ItemDetails view and VideoPlayerView. This ensures users don't lose their audio track preference when switching between between screens and reopening the audio track selection menu.

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Updated ItemDetails to persist the selected audio stream index to itemContent and update track data when audio selection changes
  • Updated ViewCreator to check if the current item has a saved selectedAudioStreamIndex and prioritize it over the global preferred audio track setting
  • Updated AudioSelector to use proper AudioTrackListData node type and consistent property naming

Testing

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan RadicalMuffinMan merged commit 80937cc into Moonfin-Client:master May 26, 2026
1 check passed
@harleykradovill harleykradovill deleted the audio branch May 26, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Unable to Select Audio Track

2 participants