Skip to content

fix What's New dialog not closing#91

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
harleykradovill:master
May 21, 2026
Merged

fix What's New dialog not closing#91
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
harleykradovill:master

Conversation

@harleykradovill
Copy link
Copy Markdown
Collaborator

Pull Request

Summary

StandardMessageDialog has its own wasClosed, and was conflicting with the custom field wasClosed. This change simply renames the field, allowing the What's New dialog to be closed by pressing OK.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Renamed wasClosed to whatsNewClosed to avoid a type mismatch

Testing

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@mattsigal
Copy link
Copy Markdown

hero

@RadicalMuffinMan RadicalMuffinMan merged commit aa0d681 into Moonfin-Client:master May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants