Skip to content

fix multiple subtitle download issues#92

Merged
RadicalMuffinMan merged 3 commits into
Moonfin-Client:masterfrom
harleykradovill:subtitle
May 21, 2026
Merged

fix multiple subtitle download issues#92
RadicalMuffinMan merged 3 commits into
Moonfin-Client:masterfrom
harleykradovill:subtitle

Conversation

@harleykradovill
Copy link
Copy Markdown
Collaborator

Pull Request

Summary

This PR fixes multiple issues on the subtitle download interface. It hides the navigation bar, sets focus on the Search button when SubtitleSearchView becomes visible, and fixes a bug causing language names to not show on the languages radio dialog.

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Set visibility on JFOverhang to false when VideoPlayerView is visible
  • Delayed focus logic when SubtitleSearchView is being initialized. The button wasn't yet available when the previous logic ran causing it to not have initial focus.
  • Fixed name mismatch for radio button description, causing no languages to load in the radio list.

Testing

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan RadicalMuffinMan merged commit b2900e3 into Moonfin-Client:master May 21, 2026
1 check passed
@harleykradovill harleykradovill deleted the subtitle branch May 21, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants