Skip to content

fix: scope focus scale to inner wrapper to avoid layout reflow #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RadicalMuffinMan merged 1 commit into from
May 10, 2026
Merged

fix: scope focus scale to inner wrapper to avoid layout reflow #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/app/src/views/Favorites/Favorites.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ className={css.itemCard}
onClick={handleItemClick}
data-index={index}
>
<div className={css.itemCardInner}>
{imageUrl ? (
<img
className={`${css.poster} ${isPerson ? css.personPoster : ''}`}
Expand All @@ -371,6 +372,7 @@ loading="lazy"
<svg viewBox="0 0 24 24"><path fill="white" d="M9 16.17L4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z"/></svg>
</div>
)}
</div>
</SpottableDiv>
);
}, [serverUrl, handleItemClick, items.length, totalCount, isLoading, loadItems, imageType, posterHeight, unifiedMode]);
Expand Down
13 changes: 11 additions & 2 deletions packages/app/src/views/Favorites/Favorites.module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,23 +156,32 @@ height: 0;
.itemCard {
position: relative;
cursor: pointer;
transition: all 0.2s ease;
border-radius: 8px;
overflow: visible;
background: transparent;
margin: 10px;

&:focus {
outline: none;
transform: scale(1.05);
z-index: 10;

.itemCardInner {
transform: scale(1.05);
}

.poster {
border-color: white;
}
}
}

.itemCardInner {
position: relative;
width: 100%;
height: 100%;
transition: transform 0.2s ease;
}

.poster {
width: 100%;
height: 270px;
Expand Down
2 changes: 2 additions & 0 deletions packages/app/src/views/Library/Library.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,7 @@ onFocus={() => {
}}
data-index={index}
>
<div className={css.itemCardInner}>
{imageUrl ? (
<img
className={css.poster}
Expand Down Expand Up @@ -777,6 +778,7 @@ loading="lazy"
<svg viewBox="0 0 24 24"><path d="M9 16.17L4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z" /></svg>
</div>
)}
</div>
</SpottableDiv>
);
}, [effectiveServerUrl, handleItemClick, items.length, totalCount, isLoading, loadItems, effectiveImageType, posterHeight, isSquareImage, isFolderView, settings]);
Expand Down
13 changes: 11 additions & 2 deletions packages/app/src/views/Library/Library.module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,23 +320,32 @@
.itemCard {
position: relative;
cursor: pointer;
transition: transform 0.2s ease;
border-radius: 8px;
overflow: visible;
background: transparent;
margin: 10px;

&:focus {
outline: none;
transform: scale(1.05);
z-index: 10;

.itemCardInner {
transform: scale(1.05);
}

.poster {
border-color: white;
}
}
}

.itemCardInner {
position: relative;
width: 100%;
height: 100%;
transition: transform 0.2s ease;
}

.poster {
width: 100%;
height: 270px;
Expand Down
Loading