Skip to content

fix intro/outro settings#206

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
nullbyze:fix-intro-outro-setting
May 20, 2026
Merged

fix intro/outro settings#206
RadicalMuffinMan merged 1 commit into
Moonfin-Client:mainfrom
nullbyze:fix-intro-outro-setting

Conversation

@nullbyze
Copy link
Copy Markdown
Contributor

Pull Request

Summary

older skipIntro wasn't replaced everywhere and therefore migrated again and again...

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • old skipIntro replaced with introAction/outroAction
  • removed default skipIntro value

Platform

  • Tizen (Samsung)
  • webOS (LG)
  • Both / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Set intro/outro Action in settings to something else
  2. Reopen Moonfin app
  3. State should now persist and the choosen action is working as expected

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

older skipIntro wasn't replaced everywhere and therefore migrated again and again... fixes Moonfin-Client#205 and Moonfin-Client#198
@github-actions
Copy link
Copy Markdown

✅ Build Successful

All platform builds passed. You can download the test artifacts below.

Platform Status Artifact
webOS ✅ Passed Moonfin_webOS_*.ipk
Tizen Regular ✅ Passed Moonfin_Tizen_Regular_*.wgt
Tizen Oblong ✅ Passed Moonfin_Tizen_Oblong_*.wgt
Tizen Legacy ✅ Passed Moonfin_Tizen_Legacy_*.wgt
Property Value
Commit df9881f
Workflow run Build #76

@RadicalMuffinMan RadicalMuffinMan merged commit eab848a into Moonfin-Client:main May 20, 2026
5 checks passed
@nullbyze nullbyze deleted the fix-intro-outro-setting branch May 21, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Skip intro option not storing, default (skip automatically) persists

2 participants