Skip to content

Fixed focus and controls timeout#215

Merged
RadicalMuffinMan merged 2 commits into
Moonfin-Client:mainfrom
nullbyze:fix-focus
May 21, 2026
Merged

Fixed focus and controls timeout#215
RadicalMuffinMan merged 2 commits into
Moonfin-Client:mainfrom
nullbyze:fix-focus

Conversation

@nullbyze
Copy link
Copy Markdown
Contributor

Pull Request

Summary

  1. Focus is not lost anymore and will stay on the selected item after a modal is closed.
  2. After a modal was opened the player controls won't hide, this doesn't happen anymore.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • added focus tracking ref, to set the focus back to the item it was before a modal was opened
  • changed showControls a little bit to synchronously set modal state

Platform

  • Tizen (Samsung)
  • webOS (LG)
  • Both / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. click on subtitle selection on player/details page
  2. close the selection/select something
  3. focus should be back to subtitle selection and not nowhere

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Focus on details and player. Also fixed the controls timeout when a modal is closed.
@github-actions
Copy link
Copy Markdown

✅ Build Successful

All platform builds passed. You can download the test artifacts below.

Platform Status Artifact
webOS ✅ Passed Moonfin_webOS_*.ipk
Tizen Regular ✅ Passed Moonfin_Tizen_Regular_*.wgt
Tizen Oblong ✅ Passed Moonfin_Tizen_Oblong_*.wgt
Tizen Legacy ✅ Passed Moonfin_Tizen_Legacy_*.wgt
Property Value
Commit da7c781
Workflow run Build #82

@RadicalMuffinMan
Copy link
Copy Markdown
Contributor

killing it lately with the PRs, thank you.

@RadicalMuffinMan
Copy link
Copy Markdown
Contributor

I really like the bot builds for testing

@RadicalMuffinMan RadicalMuffinMan merged commit e9e7600 into Moonfin-Client:main May 21, 2026
4 checks passed
@nullbyze nullbyze deleted the fix-focus branch May 22, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Focus is lost when selecting subtitles/audio/version on the details screen

2 participants