fix(bash): honor cwd for backgrounded shell commands - #2900
Conversation
🦋 Changeset detectedLatest commit: 2a1ccef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 155432823d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
1554328 to
d31244f
Compare
d31244f to
09967cf
Compare
|
@sailist Hi — a concise review-ready update: the automated review findings were addressed, including preserving the logical |
Related Issue
Resolve #2890
Problem
The Bash tool prepends
cd <cwd> &&to the user's shell script. If the first user command is backgrounded with&, Bash backgrounds that entire AND-list, includingcd, so later lines silently run in the process's original directory.What changed
Pass
cwdthrough the process execution boundary in both engine implementations and leave thebash -cinput as the user's command. Bash also receives the requested path as its logicalPWD, preserving symlinked workspace paths; on Windows the process receives a native cwd while Git Bash receives the corresponding POSIX-stylePWD. Relativecwdvalues continue to resolve from the session working directory using the target platform's path rules.Added a regression test that backgrounds the first command and verifies the following line remains in the requested directory, a real symlink-workspace test with a stale inherited
PWD, and spawn-boundary assertions for both implementations.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.