fix(cli): show the full remote control link in the startup output - #3331
Merged
Conversation
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — this is a small display fix to the experimental remote control startup output.
Problem
When remote control starts, the printed "open " line showed a shortened URL in hyperlink-capable terminals: the device id was truncated with
…, and the scheme and query parameters were dropped. The full URL only existed as the OSC-8 hyperlink target, so users who wanted to read or copy the link directly could not see it in full. Terminals without hyperlink support already printed the full URL, so the two paths were also inconsistent.What changed
formatRemoteControlOutputnow renders the full URL as the visible link text in both the hyperlink and plain-text paths. The OSC-8 wrapper is kept, so the link stays clickable in supporting terminals.shortRemoteControlUrlhelper.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset. (This PR needs no changeset.)gen-docsskill, or this PR needs no doc update. (No doc update needed.)