feat: graduate remote-control, minidb read model and search worker from experimental flags - #3552
Conversation
🦋 Changeset detectedLatest commit: 36eabde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a7e9050c6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "@moonshot-ai/kimi-code": minor | ||
| --- | ||
|
|
||
| Add the `[database]` config section: `base = false` disables the session-index read model and `search = false` runs the global search index in the server process instead of a worker thread (both default to `true`). The kill-switch environment variables are renamed to `KIMI_CODE_PERSISTENCE_MINIDB_READMODEL` and `KIMI_CODE_SEARCH_WORKER`; the old `KIMI_CODE_EXPERIMENTAL_*` names no longer apply. |
There was a problem hiding this comment.
This entry contains two long sentences and mixes the user-facing configuration addition with fallback mechanics and environment-variable migration details. Condense it to the single short statement required for release-note changesets so the generated changelog remains concise and compliant with the repository workflow.
AGENTS.md reference: AGENTS.md:L85-L86
Useful? React with 👍 / 👎.
…om experimental flags - remote-control is always available: kimi rc, kimi web --remote-control and /remote-control no longer require KIMI_CODE_EXPERIMENTAL_REMOTE_CONTROL or the master flag - add the [database] config section with base (session-index read model) and search (global search worker) kill switches, both defaulting to true - rename the kill-switch env vars to KIMI_CODE_PERSISTENCE_MINIDB_READMODEL and KIMI_CODE_SEARCH_WORKER (precedence: env > config > default)
8a7e905 to
36eabde
Compare
1 participant
Related Issue
N/A (internal change)
Problem
Remote Control, the minidb session-index read model, and the search worker have been running as experimental flags (
KIMI_CODE_EXPERIMENTAL_REMOTE_CONTROL,KIMI_CODE_EXPERIMENTAL_PERSISTENCE_MINIDB_READMODEL,KIMI_CODE_EXPERIMENTAL_SEARCH_WORKER). All three are stable enough to ship permanently: the read model and the search worker already default on, and Remote Control should not require an environment variable to unlock.What changed
kimi rc,kimi web --remote-control, and the/remote-controlslash command work out of the box. The CLI env gate, the TUIexperimentalFlaggate, and the flag registration (agent-core-v2/src/app/remoteControl/) are removed.[database]config section (agent-core-v2/src/persistence/configSection.ts): two kill switches, both defaulting totrue—base(minidb session-index read model;falsefalls back to the legacy path) andsearch(global search in a dedicated worker thread;falseruns it in the server process). Session-index services andGlobalSearchServicenow resolve through this section instead of the experimental flag registry; the latter picks its backend lazily afterIConfigService.readyso config-sourced values actually apply.EXPERIMENTALinfix):KIMI_CODE_PERSISTENCE_MINIDB_READMODELandKIMI_CODE_SEARCH_WORKER, wired through the config system's env bindings (precedence: env >[database]config > defaulttrue). The oldKIMI_CODE_EXPERIMENTAL_*names and the[experimental]keys silently stop applying.applySectionEnv), matching productionConfigServicesemantics — previously the read model was implicitly enabled in harness tests.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.