Fix field evaluation for live OHLCV bars - #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
After PR #20 merged, the first controlled MT5 canary stopped before broker execution because
stage_field_evaluationpassedmarket_state["ohlcv"]as a list of canonical bar dictionaries, whilecompute_maxwell_tensoronly supported dict-style arrays and called.get()on the list.Validation
git diff --checkpython -m pytest tests/rootfile/test_lawful_collapse_universe.py -q->13 passedpython -m pytest tests/rootfile/test_mt5_position_close_tracker.py -q->3 passedpython -m pytest tests/rootfile -q->143 passedpython -m pytest tests -q->236 passed, 9 warningsControlled MT5 canary after fix
357844399was created:SELL EURUSD_r,0.01lot, entry1.17449, SL1.17649, TP1.17049.357844399, proving the entry durability path is active.Safety
--mode bothpath was used.logs/ordata/artifacts are committed.