redteam: correct 036 attribution, verify SDK's 028-face-5 fix, re-confirm 023 - #9
Open
Morgandri1 wants to merge 2 commits into
Open
redteam: correct 036 attribution, verify SDK's 028-face-5 fix, re-confirm 023#9Morgandri1 wants to merge 2 commits into
Morgandri1 wants to merge 2 commits into
Conversation
|
Deployment failed for project wheel with the following error: Learn More: https://vercel.com/morgandri1s-projects?upgradeToPro=build-rate-limit |
…x, re-confirm 023 - 036: my first attribution pass used last-commit-author, which I then proved unreliable on myself (labeled one directory QA; a live message's sender id showed it was PM). Local git config user.name/email is the reliable signal and it independently confirms the SDK attribution that matters for the finding — the misidentified directory doesn't affect the finding itself, only which name went on a supporting example. - 028 face 5: SDK's fix (aa8be54, unmerged) checked out and built myself rather than taken on the handoff's word — find_ambiguity is now stored-only, a real clash still 409s, a declared-only overlap is a non-blocking warning returned by POST /v1/wires. Correct, ready to merge. - 023 (YAML-bomb importer): already fixed on main; re-ran all 21 import tests fresh rather than trust the finding file's own status line, given how much this file had drifted from git history earlier in this same pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ed, 031/032 status noted 034 poison-pill (escaper byte-slice panic): fixed by construction, 18/18 envelope tests pass including the exact incident regression case. 034 (journal-mode read-back vs write): fixed by consolidating the engine onto wheel-sqlite's shared, write-proven implementation instead of its own read-back-only one. 035: closed at its single sink, so the chain is moot regardless of entry point. 032: already a concluded design review, nothing to add. 031: still no code to verify. 037 (my cloud twin's blast-radius companion to 036): verified the crown-jewel claim myself rather than take it on faith — grepped config.rs and all of wheel-engine for remove_var; confirmed WHEEL_ENGINE_SECRET/WHEEL_VAULT_KEY are read via plain std::env::var and never scrubbed from the engine's own environ. The one-line interim fix it names is worth prioritizing independent of the per-node-uid timeline; flagged to PM. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Morgandri1
force-pushed
the
redteam/036-attribution-correction
branch
from
September 6, 2026 16:07
2c04f53 to
6d2378b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7 (already merged). Four things now:
git config user.name/user.email.aa8be54) checked out and built independently — confirmed correct.main(21/21 import tests).wheel-sqlitecrate. 035 is closed at its single sink. 032 is an already-concluded design review, nothing to add.WHEEL_ENGINE_SECRET/WHEEL_VAULT_KEYare read via plainstd::env::varin the engine's own config and never scrubbed from its own environ, confirmed via grep acrosswheel-enginefor everyremove_varcall.Test plan
cargo test -p wheel-engine --libtargeted tests (027/028/030) — all pass, built fresh.cargo test -p wheel-core --test envelope— 18/18 pass (034/035 regression coverage).cargo test -p wheel-engine --lib tools::import::tests::— 21/21 pass (023).make check/ docker image build (no docker in this sandbox); docs-only change, no code touched.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com