feat: InsufficientInstanceCapacity エラーを503レスポンスで返す機能の追加#76
Merged
Conversation
Morichan
commented
May 25, 2026
Morichan
commented
Owner
- close 起動時にInsufficient errorが発生した場合のレスポンスが500エラーでわかりづらい #28
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 742 826 +84
Branches 15 17 +2
=========================================
+ Hits 742 826 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Morichan
force-pushed
the
feature/insufficient-capacity
branch
from
May 25, 2026 06:05
fa2151a to
db0120d
Compare
Morichan
force-pushed
the
feature/insufficient-capacity
branch
2 times, most recently
from
May 25, 2026 07:56
55363a2 to
fea1399
Compare
- EC2Instance.State に INSUFFICIENT_CAPACITY を追加 - EC2Instance.start() で InsufficientInstanceCapacity の ClientError を キャッチし、INSUFFICIENT_CAPACITY ステートをセットするよう変更 - response.py に InsufficientCapacityState (503) を追加 - _analyze_state_from_ec2_instance() の ClientError ハンドリングで InsufficientInstanceCapacity の場合は InsufficientCapacityState を返すよう変更 - 上記に対応するユニットテストを追加
Morichan
force-pushed
the
feature/insufficient-capacity
branch
from
May 25, 2026 08:01
fea1399 to
8340e13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.