ui: port findings panel to new design#4
Open
Moriz82 wants to merge 1 commit into
Open
Conversation
Rewrites FindingsPanel.tsx to match the new-UI layout: header with totals and rerun/export actions, severity summary stats, searchable filterable list, and a detail pane with target/evidence/remediation/actions. Wires to real backend: `/api/findings?limit=5000` for list data, derives severity counts client-side. Mark as triaged / Suppress disabled (no backend persistence yet). Open in graph flips the tab via a new `onOpenInGraph` prop + matching `gossamer:open-in-graph` / `gossamer:navigate` window events so other panels can navigate without prop drilling. Adds `components/icons.tsx` and `components/Severity.tsx` as reusable primitives and `styles/screens.css` with tokens + findings selectors. Also registers the Findings tab in the Operations nav group (it was imported but never mounted before). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FindingsPanel.tsxto the new-UI two-pane layout: severity summary stats, searchable list with chip filters, and a detail pane (target / evidence / remediation / actions)./api/findings?limit=5000); severity counts are derived client-side from the list. No mock data.components/icons.tsx+components/Severity.tsxprimitives,styles/screens.csswith tokens and findings selectors.onOpenInGraphprop +gossamer:navigate/gossamer:open-in-graphwindow events so panels can flip tabs without prop drilling.Action wiring
gossamer:navigateto Operations (rescans need a scanner + target picked in that flow).onOpenInGraph(id)or falls back togossamer:open-in-graphevent.curl -sk -i '<target>'from the finding's target URL, copies to clipboard.Test plan
npx tsc --noEmitclean for all touched files (pre-existing errors in GraphPanel/OperationsPanel are unchanged).npm run buildsucceeds./, navigated to Findings, toggled a severity chip, clicked a finding row. Detail pane rendered correctly with target / evidence / remediation / actions. Zero console errors.Screenshot (1 real finding from a live crawl): Findings list + detail pane render; target extracted from the
|-delimited finding key whenmatched_at/urlare absent.🤖 Generated with Claude Code