memory: session-scoped GraphQL block, and a safe issue_write method typo - #1390
Conversation
Record two learnings from UCD-SERG/serocalculator#661's ai-config follow-up (#1389): - memories/github.md: a session's egress proxy can block GraphQL entirely (403, "only the pinned set of PR-review operations is served") even while gh api user / gh api repos/<o>/<r> both return 200 over REST --- a second, distinct root cause for the check-pr-fully-clean.py failure already tracked in #1330, alongside the pre-existing GraphQL rate-limit case. - memories/github-mcp-tools.md: issue_write's method enum only accepts "create" or "update" --- guessing "add_comment" fails loudly and safely (no data touched), distinct from the already-documented silent clobbering when method: "update" is called with just a comment string as body. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NbqvD8bSKpeTjDwYpQSHeR
|
Claude finished review — View run Code Review: PR #1390Summary: Pure documentation PR — two append-only additions to Verification performed:
No fabricated symbols, APIs, citations, or behavior descriptions were found — every technical claim in the diff was checked against either the real source code or a real, retrievable issue comment. No inline findings to post; nothing here rises to a syntax error, a definite logic error, or an unambiguous CLAUDE.md/lab-manual violation. VerdictReady for merge |
UMS pass from PR #1389's merge (
UCD-SERG/serocalculator#661follow-up).Two additions, both append-only:
memories/github.md: this session's egress proxy blocked GraphQL entirely (403: This GraphQL query is not enabled for this session) even whilegh api user/gh api repos/<o>/<r>both returned 200 over REST. That's a second, distinct root cause for thescripts/check-pr-fully-clean.pyfailure already tracked in check-pr-fully-clean.py shells out togh, so the corpus's verdict authority is unrunnable in remote/web sessions #1330 (which so far only documented the GraphQL rate-limit case) — added as a comment on check-pr-fully-clean.py shells out togh, so the corpus's verdict authority is unrunnable in remote/web sessions #1330 with the concrete evidence, and now recorded here so a future session recognizes the healthy-REST/refused-GraphQL signature immediately.memories/github-mcp-tools.md:issue_write'smethodparameter only accepts"create"or"update"— there is no"add_comment". Guessing it fails loudly and immediately (invalid method, must be either 'create' or 'update'), with no data touched — a distinct, safer failure mode from the already-documented case wheremethod: "update"with just a comment string asbodysilently clobbers the issue description. Worth distinguishing so the two aren't conflated.No files overlap with any other open PR (there are none open in this repo right now).
Self-review before push: three-dot diff scanned for banned punctuation (clean),
check-new-line-breaksrun againstorigin/main...HEAD(clean, 0 lines), no deleted lines (pure addition), both files well under the 1200-line cap (1105 and 771 lines).Generated by Claude Code