Fix LED that could stay on on quick speed changes around mid speed - #5
Open
kilrah wants to merge 2 commits into
Open
Fix LED that could stay on on quick speed changes around mid speed#5kilrah wants to merge 2 commits into
kilrah wants to merge 2 commits into
Conversation
Contributor
|
Hi @kilrah, nice find! I tested and reproduced the stuck on LED. I'm going to add some comments in the code review, let me know what you think. |
Contributor
There was a problem hiding this comment.
This makes good sense.
jacobbenlewis
added a commit
that referenced
this pull request
Oct 14, 2015
…ck speed changes -When the velocity knob is at half speed, set all LEDs off -I don't think the rest of the changes in the pull request are necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.