Repository navigation
refactor: extract reusable RL console panel - #153
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The collector test omits the required collector_device argument and fails with TypeError, while statistics handling misreports weight-publication rates and can permanently discard checkpoint notices.
3 open issues
What changed in this PR
This PR extracts reusable console-panel utilities into motrix_rl and migrates FastSAC to shared lifecycle and sampling components, laying groundwork for other RL providers.
Changes:
- Adds shared panel sessions, resource sampling, and statistics helpers.
- Separates FastSAC async statistics aggregation, rendering, and logging; passes resolved collector devices directly.
- Updates focused tests and documents the console architecture.
| File | Description |
|---|---|
wiki/design/rl-console-panel.md |
Documents shared console architecture and migration plans. |
wiki/design/index.md |
Links the console design document. |
motrix_rl/tests/test_panel_data.py |
Tests shared statistics helpers. |
motrix_rl/tests/test_console.py |
Updates imports and tests session lifecycle. |
motrix_rl/src/motrix_rl/console/panel.py |
Adds session-owned refresh and cleanup. |
motrix_rl/src/motrix_rl/console/data.py |
Adds aggregation and system-sampling utilities. |
motrix_rl/src/motrix_rl/console/__init__.py |
Exposes the shared console API. |
motrix_rl_builtin/tests/test_fastsac_live_metrics.py |
Adapts queue and rendering test hooks. |
motrix_rl_builtin/tests/test_fastsac_collector.py |
Tests explicit collector-device handoff. |
motrix_rl_builtin/tests/test_builtin_sim_backend.py |
Updates collector queue naming. |
motrix_rl_builtin/src/motrix_rl_builtin/fastsac/sync/train.py |
Uses shared sessions and samplers. |
motrix_rl_builtin/src/motrix_rl_builtin/fastsac/async_impl/worker.py |
Renames data queues and accepts resolved devices. |
motrix_rl_builtin/src/motrix_rl_builtin/fastsac/async_impl/train.py |
Integrates separate statistics consumers. |
motrix_rl_builtin/src/motrix_rl_builtin/fastsac/async_impl/stats.py |
Extracts aggregation, logging, and rendering components. |
motrix_rl_builtin/src/motrix_rl_builtin/fastsac/async_impl/collector.py |
Uses the supplied device without re-resolution. |
Review effort: Balanced
wlgys8
added a commit
that referenced
this pull request
Nov 1, 2026
wlgys8
force-pushed
the
refactor/rl-console-session
branch
from
November 1, 2026 14:06
9eda055 to
2de6508
Compare
wlgys8
added a commit
that referenced
this pull request
Nov 1, 2026
wlgys8
force-pushed
the
refactor/rl-console-session
branch
from
November 1, 2026 14:19
2de6508 to
6996c62
Compare
wlgys8
added a commit
that referenced
this pull request
Nov 1, 2026
wlgys8
force-pushed
the
refactor/rl-console-session
branch
from
November 1, 2026 14:21
6996c62 to
1e8aa28
Compare
wlgys8
added a commit
that referenced
this pull request
Nov 1, 2026
wlgys8
force-pushed
the
refactor/rl-console-session
branch
from
November 1, 2026 14:28
1e8aa28 to
be4f7d4
Compare
wlgys8
added a commit
that referenced
this pull request
Nov 1, 2026
wlgys8
force-pushed
the
refactor/rl-console-session
branch
from
November 1, 2026 14:37
be4f7d4 to
15fd256
Compare
wlgys8
added a commit
that referenced
this pull request
Nov 1, 2026
wlgys8
force-pushed
the
refactor/rl-console-session
branch
from
November 1, 2026 14:59
15fd256 to
2ada711
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The regression fixture relies on three 30-second timeouts due to incorrect expected log counts, and non-TTY output suppresses checkpoint-save notices after the first stats submission.
2 open issues
2 resolved since last review
Review effort: Balanced
wlgys8
added a commit
that referenced
this pull request
Nov 1, 2026
wlgys8
force-pushed
the
refactor/rl-console-session
branch
from
November 1, 2026 15:25
2ada711 to
2a0e3b9
Compare
wlgys8
force-pushed
the
refactor/rl-console-session
branch
from
November 1, 2026 15:42
2a0e3b9 to
a64d549
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
motrix_rl.consolepackageValidation
ruff checkon changed console and FastSAC modulespython -m compileall -qon changed Python modulesCloses #153