Repository navigation
fix(issue-167): align play_interactive.py with current env contract - #180
Merged
Merged
Conversation
- Extract RslRlVecEnvWrapper to shared module (unilab/utils/rsl_rl_vec_env_wrapper.py) - Update play_interactive.py to use shared wrapper, removing duplicate implementation - Update train_rsl_rl.py to use shared wrapper - Remove old (_, obs, _) contract compatibility branch from reset() - Add policy_obs_mode parameter support to shared wrapper - Add tests for play_interactive.py wrapper contract behavior Closes #167
TATP-233
added a commit
that referenced
this pull request
May 4, 2026
…active-contract fix(issue-167): align play_interactive.py with current env contract
TATP-233
added a commit
that referenced
this pull request
May 30, 2026
…active-contract fix(issue-167): align play_interactive.py with current env contract
TATP-233
added a commit
that referenced
this pull request
Sep 4, 2026
…active-contract fix(issue-167): align play_interactive.py with current env contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167 by aligning
play_interactive.pywith the current env contract and sharing wrapper implementation with training scripts.Changes
New shared module:
src/unilab/utils/rsl_rl_vec_env_wrapper.pyRslRlVecEnvWrapperclass supporting both training and play use casespolicy_obs_modeparameter (flatoractor) for checkpoint compatibilityreset()returns(obs_dict, info_dict)(_, obs, _)contract compatibility branchUpdated
play_interactive.py:Updated
train_rsl_rl.py:Added tests in
tests/scripts/test_train_scripts.py:test_play_wrapper_imports_shared_implementation: Verify shared importtest_play_wrapper_uses_current_reset_contract: Verify (obs, info) contracttest_play_wrapper_policy_obs_mode_actor: Verify policy_obs_mode supportVerification
Definition of Done
play_interactive.pyno longer maintains independent wrapper(_, obs, _)contract compatibility code removedplay_interactive.pycore contract behaviorCloses #167